Details
Thu, Feb 12
Change #1224676 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] JCTransformApi: Check good status consistently
Wed, Feb 11
Tue, Feb 10
Mon, Feb 9
I didn't know there was a community wish on this theme. Can you send it?
Can I close the community wishlist wish that surfaced this?
Btw the chart does work fine locally for what's worth it. Bartosz also tested it.
The README contains things that need to be added to avoid the issues that you want to fix with small iterations, so since we know it beforehand I am not 100% sure why you want to rediscover them another time.
I don't want to. In fact what I want is to import the chart and deploy it. Then add what is missing on top using the readme and feedback from the deployment as a guideline. Also because not everything is clear to me so this is also a way of absorbing the internal know how.
Will do but I would argue it's much better to deploy it, test it, see what's broken, fix and iterate until it's working as intended. Quick, small iterations.
It's a big chart and planning this waterfall style it's not going to result in something that works 100% not matter how much one spends evaluating the differences.
In the end, even if we don't import the chart we will end up copying a big portion of it anyways because we still need kserve so one way or another it will end up in the repo, perhaps adapted but still.
@DPogorzelski-WMF please check https://gerrit.wikimedia.org/r/plugins/gitiles/operations/deployment-charts/+/refs/heads/master/charts/kserve/README, there is a little more :) Not sure what it is still required or not, but worth to keep it mind when checking the upstream chart.
It seems that the major difference is the fact that we have a calico network policy but the chart doesn't (unsurprisingly). Perhaps we can supply that out of band.
Our images expect /usr/bin/manager but upstream uses /manager and this is not configurable. We might want to update our images to use the upstream path.
Fri, Feb 6
@JMeybohm will check and update the ticket, cheers!
@MLechvien-WMF i am happy to follow up with Dawid and the review the charts etc.., but as Janis pointed out SRE should not lead the efforts to import the chart :)
We have a rough documentation about our policy and process around adopting upstream helm charts which can be found here: https://wikitech.wikimedia.org/wiki/Kubernetes/Upstream_Helm_charts_policy
@elukey assigning this to you as you're noted as reviewer on https://wikitech.wikimedia.org/wiki/Helm/Upstream_Charts/kserve
Even with resizing image container templates like image frame, the pie charts at least have way too much whitespace below them. See:
Thu, Feb 5
to be noted that we already use kserve in the ML context installed via:
https://gerrit.wikimedia.org/r/plugins/gitiles/operations/deployment-charts/+/refs/heads/master/helmfile.d/admin_ng/kserve/
and
https://gerrit.wikimedia.org/r/plugins/gitiles/operations/deployment-charts/+/refs/heads/master/helmfile.d/admin_ng/knative-serving/
Wed, Feb 4
Tue, Feb 3
We are putting this back in our Backlog column until we get some tests in place.
Mon, Feb 2
Given that we now know what the intended behaviour is, we can estimate it properly going into next sprint. cc @HSwan-WMF
realizes weeks later that he forgot to hit submit on this comment...
Ok, I have reverted the production system to the version from last June that was previously running. We can fix things up on master in gitlab, then after more thorough testing we can push that back out to production.
Change #1235860 merged by jenkins-bot:
[operations/deployment-charts@master] Revert "Update chart-renderer to 2026-01-29-153835-production"
Change #1235858 merged by jenkins-bot:
[operations/deployment-charts@master] Reapply "Update chart-renderer service for Parsoid template fix"
Change #1235860 had a related patch set uploaded (by Bvibber; author: Bvibber):
[operations/deployment-charts@master] Revert "Update chart-renderer to 2026-01-29-153835-production"
Change #1235858 had a related patch set uploaded (by Bvibber; author: Bvibber):
[operations/deployment-charts@master] Reapply "Update chart-renderer service for Parsoid template fix"
Change #1235853 merged by jenkins-bot:
[operations/deployment-charts@master] Revert "Update chart-renderer service for Parsoid template fix"
In team meeting today we agreed to revert the partial fix until a fix without the regression is in place and tested. Working on the revert now...
Change #1235853 had a related patch set uploaded (by Bvibber; author: Bvibber):
[operations/deployment-charts@master] Revert "Update chart-renderer service for Parsoid template fix"