Page MenuHomePhabricator
Create Task
Maniphest T94401

Fix easy problems reported by RuboCop in mediawiki/extensions/CentralAuth
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fixed Style/SpaceInsideParens RuboCop offensemediawiki/extensions/CentralAuthmaster+1 -14
Fixed Style/SpaceAfterColon RuboCop offensemediawiki/extensions/CentralAuthmaster+1 -6
Fixed Style/RedundantSelf RuboCop offensemediawiki/extensions/CentralAuthmaster+1 -6
Fixed Style/LeadingCommentSpace RuboCop offensemediawiki/extensions/CentralAuthmaster+0 -8
Fixed Style/AlignParameters RuboCop offensemediawiki/extensions/CentralAuthmaster+4 -8
Regenerate RuboCop TODO + fix StringLiteralsmediawiki/extensions/CentralAuthmaster+15 -35
Fixed Style/StringLiterals RuboCop offensemediawiki/extensions/CentralAuthmaster+14 -20
Regenerated RuboCop TODO filemediawiki/extensions/CentralAuthrefs/changes/54/200554/4+5 -19
Update RuboCop version and configuration filemediawiki/extensions/CentralAuthmaster+27 -8
Update Ruby gemsmediawiki/extensions/CentralAuthmaster+16 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Mar 30 2015, 12:56 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Low.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added projects: Browser-Tests-Infrastructure, MediaWiki-extensions-CentralAuth.
zeljkofilipin added subscribers: dduvall, zeljkofilipin.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2015, 12:56 PM
gerritbot subscribed.Mar 30 2015, 1:23 PM

Change 200554 had a related patch set uploaded (by Zfilipin):
Update RuboCop configuration file

https://gerrit.wikimedia.org/r/200554

gerritbot added a project: Patch-For-Review.Mar 30 2015, 1:23 PM

Change 200555 had a related patch set uploaded (by Zfilipin):
Update Ruby gems

https://gerrit.wikimedia.org/r/200555

gerritbot added a comment.Mar 30 2015, 1:23 PM

Change 200556 had a related patch set uploaded (by Zfilipin):
Regenerated RuboCop TODO file

https://gerrit.wikimedia.org/r/200556

gerritbot added a comment.Mar 30 2015, 1:23 PM

Change 200557 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/200557

gerritbot added a comment.Mar 30 2015, 1:23 PM

Change 200558 had a related patch set uploaded (by Zfilipin):
Fixed Style/AlignParameters RuboCop offense

https://gerrit.wikimedia.org/r/200558

gerritbot added a comment.Mar 30 2015, 1:23 PM

Change 200559 had a related patch set uploaded (by Zfilipin):
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/200559

gerritbot added a comment.Mar 30 2015, 1:23 PM

Change 200560 had a related patch set uploaded (by Zfilipin):
Fixed Style/RedundantSelf RuboCop offense

https://gerrit.wikimedia.org/r/200560

gerritbot added a comment.Mar 30 2015, 1:23 PM

Change 200561 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAfterColon RuboCop offense

https://gerrit.wikimedia.org/r/200561

gerritbot added a comment.Mar 30 2015, 1:23 PM

Change 200562 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceInsideParens RuboCop offense

https://gerrit.wikimedia.org/r/200562

zeljkofilipin closed this task as Resolved.Mar 30 2015, 1:23 PM
zeljkofilipin set Security to None.
gerritbot added a comment.Mar 31 2015, 10:57 AM

Change 200555 abandoned by Zfilipin:
Update Ruby gems

Reason:
updated rubocop in another commit

https://gerrit.wikimedia.org/r/200555

zeljkofilipin moved this task from Inbox to Done on the Browser-Tests-Infrastructure board.Mar 31 2015, 1:27 PM
gerritbot added a comment.Mar 31 2015, 7:44 PM

Change 200960 had a related patch set uploaded (by Hashar):
Regenerated RuboCop TODO file

https://gerrit.wikimedia.org/r/200960

gerritbot added a comment.Mar 31 2015, 7:45 PM

Change 200554 merged by jenkins-bot:
Update RuboCop version and configuration file

https://gerrit.wikimedia.org/r/200554

Diffusion mentioned this in rMEXT4163450a6235: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Mar 31 2015, 7:45 PM
gerritbot added a comment.Mar 31 2015, 7:45 PM

Change 200960 abandoned by Hashar:
Regenerated RuboCop TODO file

https://gerrit.wikimedia.org/r/200960

zeljkofilipin mentioned this in rECAUc384bb5d3b09: Update RuboCop version and configuration file.Mar 31 2015, 7:46 PM
gerritbot added a comment.Apr 3 2015, 8:44 AM

Change 200557 abandoned by Hashar:
Fixed Style/StringLiterals RuboCop offense

Reason:
Squashed in previous patch using git rebase --interactive

https://gerrit.wikimedia.org/r/200557

gerritbot added a comment.Apr 3 2015, 8:48 AM

Change 200556 merged by jenkins-bot:
Regenerate RuboCop TODO fix StringLiterals

https://gerrit.wikimedia.org/r/200556

Diffusion mentioned this in rMEXTbbca586ae1b2: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Apr 3 2015, 8:48 AM
hashar mentioned this in rECAU38b0268f65a5: Regenerate RuboCop TODO + fix StringLiterals.Apr 3 2015, 8:49 AM
gerritbot added a comment.Apr 3 2015, 8:58 AM

Change 200558 merged by jenkins-bot:
Fixed Style/AlignParameters RuboCop offense

https://gerrit.wikimedia.org/r/200558

gerritbot added a comment.Apr 3 2015, 8:58 AM

Change 200559 merged by jenkins-bot:
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/200559

gerritbot added a comment.Apr 3 2015, 8:58 AM

Change 200560 merged by jenkins-bot:
Fixed Style/RedundantSelf RuboCop offense

https://gerrit.wikimedia.org/r/200560

zeljkofilipin mentioned this in rMEXT302ca3241134: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Apr 3 2015, 8:58 AM
gerritbot added a comment.Apr 3 2015, 8:58 AM

Change 200561 merged by jenkins-bot:
Fixed Style/SpaceAfterColon RuboCop offense

https://gerrit.wikimedia.org/r/200561

hashar mentioned this in rECAU7de681859be6: Fixed Style/AlignParameters RuboCop offense.Apr 3 2015, 8:58 AM
hashar mentioned this in rECAU04a9d9af29b2: Fixed Style/LeadingCommentSpace RuboCop offense.
hashar mentioned this in rECAUe46f6b1f8bda: Fixed Style/RedundantSelf RuboCop offense.
hashar mentioned this in rECAU337cbaf5685a: Fixed Style/SpaceAfterColon RuboCop offense.
zeljkofilipin mentioned this in rMEXT60cea8e439af: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Apr 3 2015, 8:59 AM
zeljkofilipin mentioned this in rMEXT4e43a15eb276: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….
zeljkofilipin mentioned this in rMEXT114a2bd37e6b: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….
gerritbot added a comment.Apr 7 2015, 8:36 AM

Change 200562 merged by jenkins-bot:
Fixed Style/SpaceInsideParens RuboCop offense

https://gerrit.wikimedia.org/r/200562

zeljkofilipin mentioned this in rMEXTb37eba89d1ae: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Apr 7 2015, 8:36 AM
hashar subscribed.Apr 7 2015, 8:36 AM

https://gerrit.wikimedia.org/r/#/c/200562/ fixed the remaining RuboCop issue.

hashar mentioned this in rECAUed54c4116bbd: Fixed Style/SpaceInsideParens RuboCop offense.Apr 7 2015, 8:37 AM
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.May 5 2015, 5:46 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Sep 11 2015, 3:28 PM
greg added a project: Essential-Work.Sep 21 2015, 8:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits