Page MenuHomePhabricator
Create Task
Maniphest T93813

Change the "Collections" icon in left nav menu
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

plus_icon.svg573 BDownload

I'm attaching an svg of the icon here.

Details

SubjectRepoBranchLines +/-
Abuse the hook to add all icons to Minervamediawiki/extensions/Gathermaster+2 -0
Add collections icon to menumediawiki/extensions/Gathermaster+8 -1
Customize query in gerrit

Related Objects

Event Timeline

• MSyed created this task.Mar 24 2015, 10:06 PM
• MSyed assigned this task to • JKatzWMF.
• MSyed raised the priority of this task from to Needs Triage.
• MSyed updated the task description. (Show Details)
• MSyed subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2015, 10:06 PM
• MSyed added a project: Gather.Mar 24 2015, 10:06 PM
• MSyed set Security to None.
• JKatzWMF added a comment.Mar 24 2015, 10:23 PM

This is where the icon should go:

Screenshot_2015-03-24_15.22.32.png (526×403 px, 83 KB)

Jdlrobson added a project: Gather Sprint Enwiki.Mar 30 2015, 4:35 PM
Jdlrobson moved this task from Needs triage to In sprint on the Gather board.
• JKatzWMF removed • JKatzWMF as the assignee of this task.Mar 30 2015, 5:54 PM
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Enwiki board.Mar 30 2015, 5:58 PM
Jdlrobson edited a custom field.
• Jhernandez claimed this task.Mar 31 2015, 10:41 AM
• Jhernandez moved this task from Ready for dev to In development on the Gather Sprint Enwiki board.
gerritbot subscribed.Mar 31 2015, 11:18 AM

Change 200847 had a related patch set uploaded (by Jhernandez):
Add collections icon to menu

https://gerrit.wikimedia.org/r/200847

gerritbot added a project: Patch-For-Review.Mar 31 2015, 11:18 AM
• Jhernandez added a comment.Mar 31 2015, 11:22 AM

Added icon. I've had to edit it to change the color to white and the document size to something a bit more square or the icon would be scaled and be too small (document size was 1280x800, changed it to 1000x800). Also optimized with svgo.

How it looks:

Screen_Shot_2015-03-31_at_1.18.46_PM.png (460×394 px, 47 KB)

The edited icon:

plus.svg341 BDownload

• Jhernandez moved this task from In development to Code review needed on the Gather Sprint Enwiki board.Mar 31 2015, 11:22 AM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Enwiki board.Mar 31 2015, 4:50 PM
gerritbot added a comment.Mar 31 2015, 4:52 PM

Change 200847 merged by jenkins-bot:
Add collections icon to menu

https://gerrit.wikimedia.org/r/200847

Diffusion mentioned this in rMEXT2409378107d4: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 31 2015, 4:52 PM
Jdlrobson subscribed.Apr 1 2015, 8:50 PM

I'm not seeing it @Jhernandez on http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=beta ...

Jdlrobson moved this task from Ready for signoff to Needs more development (-1) on the Gather Sprint Enwiki board.Apr 1 2015, 8:50 PM
Jdlrobson merged a task: T94777: Collection icon not appearing in menu..Apr 1 2015, 11:24 PM

I think something might have happened with the ResourceLoader image module.

Jdlrobson moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Enwiki board.Apr 2 2015, 9:06 PM
gerritbot added a comment.Apr 2 2015, 9:07 PM

Change 201592 had a related patch set uploaded (by Jdlrobson):
Abuse the hook to add all icons to Minerva

https://gerrit.wikimedia.org/r/201592

Jdlrobson added a comment.Apr 2 2015, 9:09 PM

It was showing only on special pages. I'm abusing the hook in this patchset but it will do the job for the time being. See T93257

• Jhernandez added a comment.Apr 3 2015, 11:42 AM

Had to change addModuleStyles to addModules to get it to work actually. But it seems to work now. (Patch is merging, ) can you confirm @Jdlrobson?

gerritbot added a comment.Apr 3 2015, 11:44 AM

Change 201592 merged by jenkins-bot:
Abuse the hook to add all icons to Minerva

https://gerrit.wikimedia.org/r/201592

Diffusion mentioned this in rMEXT892fbcc994a8: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Apr 3 2015, 11:44 AM
Jdlrobson added a comment.Apr 3 2015, 4:39 PM

@Jhernandez see T95014

Jdlrobson closed this task as Resolved.Apr 3 2015, 4:39 PM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Enwiki board.
Jdlrobson merged a task: T91356: Collection's have their own icon--separated out from Watchlist..Apr 3 2015, 9:01 PM
Jdlrobson added a subscriber: • JKatzWMF.
Diffusion mentioned this in rEGAT1b77e1d5d662: Add collections icon to menu.Apr 8 2015, 6:17 PM
Jdlrobson mentioned this in rEGAT399a312d238a: Abuse the hook to add all icons to Minerva.Apr 8 2015, 6:17 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Enwiki board.Apr 9 2015, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits