Page MenuHomePhabricator
Create Task
Maniphest T92705

Regression: interstitial page with PayPal even when the amount is good.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  • Visit donate.wmo
  • Select a value
  • Click "PayPal"

You will see an interstitial page, which should only happen if something is wrong and needs to be corrected.

Details

SubjectRepoBranchLines +/-
Test that we are skipping the PP interstitialmediawiki/extensions/DonationInterfacemaster+21 -0
Hardcode PayPal gateway to always redirect, if possiblemediawiki/extensions/DonationInterfacemaster+9 -0
Be more discriminating about the "redirect" parammediawiki/extensions/DonationInterfacemaster+13 -4
Respect "redirect" param if availablemediawiki/extensions/DonationInterfacemaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Mar 14 2015, 1:22 AM
awight raised the priority of this task from to High.
awight updated the task description. (Show Details)
awight added projects: Fundraising-Backlog-Old, Wikimedia-Fundraising.
awight subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2015, 1:22 AM
• atgo added a project: Fundraising Sprint Grandmaster Flash.Mar 16 2015, 6:01 PM
• atgo subscribed.
Pcoombe subscribed.Mar 16 2015, 7:59 PM
Pcoombe added a comment.EditedMar 16 2015, 8:05 PM

Ah, you beat me to it. This is also happening when donating from banners. I can't tell when this started, but nothing has changed in banners or donatewiki recently which should have affected this.

awight added a subscriber: • MeganHernandez_WMF.Mar 16 2015, 8:13 PM

I'm pretty sure this was caused by a refactor I did of the DonationInterface forms layer, deployed Mar 12. CC'ing @MeganHernandez_WMF, this is almost certainly decreasing PP conversion rates.

• atgo added a comment.Mar 16 2015, 8:15 PM

It's probably coming from the DI deploy last week. We'll look into it ASAP

• atgo set Security to None.Mar 18 2015, 11:09 PM
• atgo edited a custom field.
• MeganHernandez_WMF added a comment.Mar 19 2015, 9:21 AM

Hey guys, We are holding off on extra Spanish tests & emails. An extra step is bad in general and that page is especially strange since the PayPal button isn't actually a button.

Any update if we can get rid of this? Maybe revert the change that caused this?

• MeganHernandez_WMF added subscribers: • jrobell, • Ppena, • CCogdill_WMF.Mar 19 2015, 9:22 AM
awight raised the priority of this task from High to Unbreak Now!.Mar 19 2015, 2:25 PM

Escalating the priority cos it's blocking the Spanish campaign.

awight moved this task from Backlog to Doing on the Fundraising Sprint Grandmaster Flash board.Mar 19 2015, 5:12 PM
gerritbot subscribed.Mar 19 2015, 5:17 PM

Change 197946 had a related patch set uploaded (by Awight):
Respect "redirect" param if available

https://gerrit.wikimedia.org/r/197946

gerritbot added a project: Patch-For-Review.Mar 19 2015, 5:17 PM

Change 197947 had a related patch set uploaded (by Awight):
Be more discriminating about the "redirect" param

https://gerrit.wikimedia.org/r/197947

gerritbot added a comment.Mar 19 2015, 5:21 PM

Change 197950 had a related patch set uploaded (by Awight):
Hardcode PayPal gateway to always redirect, if possible

https://gerrit.wikimedia.org/r/197950

awight moved this task from Doing to Review on the Fundraising Sprint Grandmaster Flash board.Mar 19 2015, 5:21 PM
gerritbot added a comment.Mar 19 2015, 5:26 PM

Change 197946 merged by jenkins-bot:
Respect "redirect" param if available

https://gerrit.wikimedia.org/r/197946

gerritbot added a comment.Mar 19 2015, 5:41 PM

Change 197947 merged by jenkins-bot:
Be more discriminating about the "redirect" param

https://gerrit.wikimedia.org/r/197947

gerritbot added a comment.Mar 19 2015, 5:41 PM

Change 197950 merged by jenkins-bot:
Hardcode PayPal gateway to always redirect, if possible

https://gerrit.wikimedia.org/r/197950

awight moved this task from Review to Done on the Fundraising Sprint Grandmaster Flash board.Mar 19 2015, 5:47 PM
gerritbot added a comment.Mar 19 2015, 6:31 PM

Change 197973 had a related patch set uploaded (by Awight):
Test that we are skipping the PP interstitial

https://gerrit.wikimedia.org/r/197973

• atgo closed this task as Resolved.Mar 19 2015, 10:57 PM
gerritbot added a comment.Mar 20 2015, 5:08 PM

Change 197973 merged by jenkins-bot:
Test that we are skipping the PP interstitial

https://gerrit.wikimedia.org/r/197973

awight mentioned this in rMEXT1ff53d19f62c: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 23 2015, 3:55 PM
awight mentioned this in rMEXT027cc5d1e442: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
awight mentioned this in rMEXT9979ee4044d1: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Diffusion mentioned this in rMEXT4e431ed6441c: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 23 2015, 3:56 PM
awight mentioned this in rEDOI0b9f3c3b3e18: Respect "redirect" param if available.Mar 23 2015, 3:57 PM
awight mentioned this in rEDOI680789db709b: Be more discriminating about the "redirect" param.
awight mentioned this in rEDOIb703602e20a6: Hardcode PayPal gateway to always redirect, if possible.
awight mentioned this in rEDOI99bb608adea5: Test that we are skipping the PP interstitial.
Pcoombe mentioned this in T58657: Donate via PayPal from [[wmf:Ways to Give]] says "Please correct the errors in your donation amount".Mar 26 2015, 6:19 PM
• atgo added a project: Fundraising-Backlog.Jun 30 2015, 10:15 PM
• atgo moved this task from Triage to Closed Sprint Work Q3 1415 on the Fundraising-Backlog board.Jun 30 2015, 10:19 PM
• atgo unsubscribed.Mar 30 2016, 10:03 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:44 PM
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 22 2017, 9:44 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits