S12. Flow Notifications are not marked as read by visiting the Topic page
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

If I click on the link in the Echo Flyout, for a new topic in a Flow board, I go to the Topic page. But the badge number doesn't change, and the item in the flyout is still marked as unread.
If I go to the Board itself, then the Notification is marked as read.
This is backwards from the spec.

Details

	Subject	Repo	Branch	Lines +/-
	Mark new topic notifications read from both board and topic pages	mediawiki/extensions/Flow	master	+4 -1
	Allow multiple target pages per event	mediawiki/extensions/Echo	master	+174 -55

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	matthiasmullie	T95860 A6. Notifications resulting from a conversation in flow do not disappear after visiting the page.
Resolved	EBernhardson	T85064 S12. Flow Notifications are not marked as read by visiting the Topic page
Resolved	jcrespo	T94427 Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many.

Event Timeline

Quiddity created this task.Dec 20 2014, 7:36 PM

Quiddity raised the priority of this task from to High.

Quiddity updated the task description. (Show Details)

Quiddity added projects: Notifications (Echo), StructuredDiscussions, Collaboration-Team-Triage.

Quiddity changed Security from none to None.

Quiddity subscribed.

• DannyH moved this task from Untriaged to Ready for next sprint on the Collaboration-Team-Triage board.Mar 7 2015, 12:07 AM

• DannyH moved this task from Ready for next sprint to Team discussion on the Collaboration-Team-Triage board.Mar 11 2015, 4:44 PM

• DannyH edited a custom field.Mar 11 2015, 6:41 PM

• DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.

• DannyH moved this task from Ready for next sprint to Sprint S (temporary for meeting) on the Collaboration-Team-Triage board.Mar 11 2015, 6:43 PM

EBernhardson added a project: Collaboration-Team-Sprint-S-2015-03-25.Mar 11 2015, 9:28 PM

• DannyH renamed this task from Flow Notifications are not marked as read by visiting the Topic page to S12. Flow Notifications are not marked as read by visiting the Topic page.Mar 11 2015, 9:48 PM

• DannyH removed a project: Collaboration-Team-Triage.Mar 11 2015, 9:52 PM

EBernhardson claimed this task.Mar 12 2015, 10:57 PM

EBernhardson moved this task from Sprint S - ends March 25 to In Development on the Collaboration-Team-Sprint-S-2015-03-25 board.

Change 197069 had a related patch set uploaded (by EBernhardson):
Allow multiple target pages per event

https://gerrit.wikimedia.org/r/197069

gerritbot added a project: Patch-For-Review.Mar 16 2015, 3:53 PM

This is in code review for the first half. The second half, adding a second targetpage to the event is fairly trivial and will be done after reviewing the above patch.

EBernhardson moved this task from In Development to Needs Code Review on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 16 2015, 3:53 PM

Change 197075 had a related patch set uploaded (by EBernhardson):
Mark new topic notifications read from both board and topic pages

https://gerrit.wikimedia.org/r/197075

EBernhardson moved this task from Needs Code Review to Code Review Started on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 16 2015, 11:14 PM

EBernhardson moved this task from Code Review Started to Needs Code Review on the Collaboration-Team-Sprint-S-2015-03-25 board.

matthiasmullie moved this task from Needs Code Review to Code Review Started on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 20 2015, 2:29 PM

• DannyH added a project: Collaboration-Team-Sprint-T-2015-04-08.Mar 25 2015, 7:21 PM

• DannyH moved this task from Sprint T - ends April 8 to Code Review Started on the Collaboration-Team-Sprint-T-2015-04-08 board.

Change 197069 merged by jenkins-bot:
Allow multiple target pages per event

https://gerrit.wikimedia.org/r/197069

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 31 2015, 7:59 AM

EBernhardson mentioned this in rMEXT79ba4733b1d5: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Mar 31 2015, 8:00 AM

matthiasmullie mentioned this in rECHO70639162f341: Allow multiple target pages per event.Mar 31 2015, 8:02 AM

Echo patch merged. Waiting for Echo schema change to be applied before merging Flow patch.

• Mattflaschen-WMF mentioned this in T94943: echo notifications linking to hidden posts don't get marked as read when the link is followed .Apr 3 2015, 1:03 AM

EBernhardson added a subtask: T94427: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many..Apr 6 2015, 6:51 PM

Not sure where exactly this belongs, its not waiting for code review so doesn't belong there. It is just blocked waiting on production schema changes before we can make this live in production.

• DannyH added a project: Collaboration-Team-Sprint-U-2015-04-22.Apr 8 2015, 10:17 PM

• DannyH moved this task from Sprint U - ends April 22 to Product Review on the Collaboration-Team-Sprint-U-2015-04-22 board.