Page MenuHomePhabricator
Create Task
Maniphest T414193

[MEX][QC] Add support for displaying multiple violations and bad-parameter constraint check failures
Open, Needs TriagePublic
Actions

Description

T411608 implemented support for showing details of QualityConstraints check failures in a popover in the wbui2025 interface. The currently implementation can only show a single issue - if there are multiple issues, it shows only one - and cannot display 'advanced issues' (which are only displayed if multiple issues are present in the existing desktop implementation).

Complete the implementation of multiple-issues pop-ups per the figma designs:

Screenshot 2025-12-02 at 15.14.38.png (1×2 px, 251 KB)

Screenshot 2025-12-02 at 15.14.56.png (1×1 px, 181 KB)

FIGMA LINK

Acceptance Criteria

  • Display of single violations works as previously implemented
  • If multiple violations are present, the multistep dialog replaces the existing pop-up, and allows users to click through the details of each of the violations
    • A single icon is displayed for the multiple violations
    • The icon used is the icon for the most "severe" violation
  • bad-parameter / advanced issues are supported and displayed in the dialog.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Tidy tests related to wbui2025mediawiki/extensions/WikibaseQualityConstraintsmaster+172 -241
Clean up backwards compatibility for WBQC popover htmlmediawiki/extensions/Wikibasemaster+1 -13
Show multiple issues in a popover in wbui2025mediawiki/extensions/WikibaseQualityConstraintsmaster+616 -63
POC: Make popover contents a list of refs of listsmediawiki/extensions/Wikibasemaster+21 -21
Multiple issues in popovermediawiki/extensions/Wikibasemaster+409 -50
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.Jan 9 2026, 12:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2026, 12:27 PM
ArthurTaylor attached a referenced file: F70820179: Screenshot 2025-12-02 at 15.14.56.png. (Show Details)Jan 9 2026, 12:27 PM
ArthurTaylor attached a referenced file: F70820177: Screenshot 2025-12-02 at 15.14.38.png. (Show Details)
ArthurTaylor added a parent task: T411026: [MEX] First Pass - Constraint violation extension is used by wbui2025.
ArthurTaylor added a project: Wikidata-Omega.Jan 9 2026, 12:29 PM
ArthurTaylor moved this task from Incoming to Ready for Task Time (Story Writing) on the Wikidata-Omega board.
ArthurTaylor mentioned this in T411609: [MEX][QC] Wire together quality contraints icons and popovers for MEX and cover with end-to-end tests.Jan 12 2026, 9:32 AM
ArthurTaylor updated the task description. (Show Details)Jan 13 2026, 10:01 AM
karapayneWMDE moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.Jan 13 2026, 10:01 AM
karapayneWMDE added a parent task: T400676: [MEX][SPIKE] Constraint violation indicators and tooltips should be shown.
AudreyPenven_WMDE claimed this task.Jan 13 2026, 10:53 AM
AudreyPenven_WMDE moved this task from The Backlog to The Board on the Wikidata-Omega board.
AudreyPenven_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
AudreyPenven_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE mentioned this in T412145: [MEX][Score] Display Lilypond errors for statement values.Jan 13 2026, 4:47 PM
gerritbot added a comment.Mon, Jan 19, 10:07 AM

Change #1228431 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] [WIP] Multiple issues in popover

https://gerrit.wikimedia.org/r/1228431

gerritbot added a project: Patch-For-Review.Mon, Jan 19, 10:07 AM
gerritbot added a comment.Mon, Jan 19, 10:09 AM

Change #1228434 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/WikibaseQualityConstraints@master] [WIP] show multiple issues in wbui2025

https://gerrit.wikimedia.org/r/1228434

AudreyPenven_WMDE created subtask T415256: [MEX] [BUG] [QC] clear constraint violation indicators and messages if an edit fixes them.Thu, Jan 22, 12:48 PM
gerritbot added a comment.Fri, Jan 23, 5:02 PM

Change #1230966 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] POC: Make popover contents a list of refs of lists

https://gerrit.wikimedia.org/r/1230966

gerritbot added a comment.Wed, Jan 28, 11:51 AM

Change #1234333 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] Clean up backwards compatibility for WBQC popover html

https://gerrit.wikimedia.org/r/1234333

AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Tue, Feb 3, 5:52 PM
AudreyPenven_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
AudreyPenven_WMDE subscribed.
Lucas_Werkmeister_WMDE claimed this task.Wed, Feb 4, 11:30 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Wed, Feb 4, 3:24 PM

Change #1228431 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Multiple issues in popover

https://gerrit.wikimedia.org/r/1228431

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Wed, Feb 4, 4:00 PM
gerritbot added a comment.Fri, Feb 6, 10:42 AM

Change #1230966 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] POC: Make popover contents a list of refs of lists

Reason:

superseded by Ibd71713995 (I think sooner or later a reactive version of the constraint indicators would still be useful, but we can figure that out later)

https://gerrit.wikimedia.org/r/1230966

Lucas_Werkmeister_WMDE reassigned this task from Lucas_Werkmeister_WMDE to AudreyPenven_WMDE.Tue, Feb 10, 1:18 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to In Development on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE subscribed.
gerritbot added a comment.Tue, Feb 10, 1:25 PM

Change #1228434 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Show multiple issues in a popover in wbui2025

https://gerrit.wikimedia.org/r/1228434

gerritbot added a comment.Tue, Feb 10, 1:33 PM

Change #1234333 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Clean up backwards compatibility for WBQC popover html

https://gerrit.wikimedia.org/r/1234333

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.16; 2026-02-17); removed MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Tue, Feb 10, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Feb 10, 2:32 PM
gerritbot added a comment.Tue, Feb 10, 5:50 PM

Change #1238404 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/WikibaseQualityConstraints@master] Tidy tests related to wbui2025

https://gerrit.wikimedia.org/r/1238404

gerritbot added a project: Patch-For-Review.Tue, Feb 10, 5:50 PM
AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Wed, Feb 11, 4:49 PM
AudreyPenven_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Thu, Feb 12, 1:40 PM

Change #1238404 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Tidy tests related to wbui2025

https://gerrit.wikimedia.org/r/1238404

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.Thu, Feb 12, 1:47 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, Feb 12, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits