Page MenuHomePhabricator

Using null as an array offset is deprecated, use an empty string instead (from Deferred/LinksUpdate/ExternalLinksTable.php:54)
Closed, ResolvedPublic

Description

  • mediawiki/core locally running PHP 8.5
  • composer phpunit:entrypoint -- --filter LinksUpdateTest
1) LinksUpdateTest::testUpdate_externallinksWrongOldEntry
Using null as an array offset is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Deferred/LinksUpdate/ExternalLinksTable.php:54
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/ExternalLinksTable.php:81
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/LinksTable.php:361
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/LinksUpdate.php:211
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/LinksUpdate.php:171
/[...]/mediawiki/core/tests/phpunit/includes/Deferred/LinksUpdateTest.php:890
/[...]/mediawiki/core/tests/phpunit/includes/Deferred/LinksUpdateTest.php:875
/[...]/mediawiki/core/tests/phpunit/includes/Deferred/LinksUpdateTest.php:274

(note: not yet seen in WMF experimental CI due to the order in which it runs MediaWiki's PHPUnit tests, but it presumably would be seen there at some point)

Event Timeline

Change #1229672 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1229672

Change #1229672 merged by jenkins-bot:

[mediawiki/core@master] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1229672

Change #1232576 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_45] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232576

Change #1232577 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_44] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232577

Change #1232578 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_43] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232578

Change #1232578 merged by jenkins-bot:

[mediawiki/core@REL1_43] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232578

Change #1232577 merged by jenkins-bot:

[mediawiki/core@REL1_44] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232577

Change #1232576 merged by jenkins-bot:

[mediawiki/core@REL1_45] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232576