ExternalLinksTable.php:54)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	A_smart_kitten
	Jan 6 2026, 9:27 PM

Description

mediawiki/core locally running PHP 8.5
composer phpunit:entrypoint -- --filter LinksUpdateTest

1) LinksUpdateTest::testUpdate_externallinksWrongOldEntry
Using null as an array offset is deprecated, use an empty string instead

/[...]/mediawiki/core/includes/Deferred/LinksUpdate/ExternalLinksTable.php:54
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/ExternalLinksTable.php:81
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/LinksTable.php:361
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/LinksUpdate.php:211
/[...]/mediawiki/core/includes/Deferred/LinksUpdate/LinksUpdate.php:171
/[...]/mediawiki/core/tests/phpunit/includes/Deferred/LinksUpdateTest.php:890
/[...]/mediawiki/core/tests/phpunit/includes/Deferred/LinksUpdateTest.php:875
/[...]/mediawiki/core/tests/phpunit/includes/Deferred/LinksUpdateTest.php:274

(note: not yet seen in WMF experimental CI due to the order in which it runs MediaWiki's PHPUnit tests, but it presumably would be seen there at some point)

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate	mediawiki/core	master	+1 -1
LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate	mediawiki/core	REL1_45	+1 -1
LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate	mediawiki/core	REL1_44	+1 -1
LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate	mediawiki/core	REL1_43	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T410514 Using null as array offset or as the key parameter for array_key_exists() is deprecated in PHP 8.5
		Resolved		Umherirrender	T413921 Using null as an array offset is deprecated, use an empty string instead (from Deferred/LinksUpdate/ExternalLinksTable.php:54)

Event Timeline

A_smart_kitten created this task.Jan 6 2026, 9:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2026, 9:27 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Jan 6 2026, 9:36 PM

A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 12 2026, 11:11 AM

Umherirrender claimed this task.Jan 21 2026, 8:07 PM

Change #1229672 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1229672

gerritbot added a project: Patch-For-Review.Jan 21 2026, 8:07 PM

Change #1229672 merged by jenkins-bot:

[mediawiki/core@master] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1229672

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2026, 2:30 PM

Change #1232576 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_45] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232576

Change #1232577 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_44] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232577

Change #1232578 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_43] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232578

Umherirrender closed this task as Resolved.Jan 25 2026, 2:53 PM

Umherirrender removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.13; 2026-01-27).Jan 25 2026, 3:00 PM

Change #1232578 merged by jenkins-bot:

[mediawiki/core@REL1_43] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232578

Change #1232577 merged by jenkins-bot:

[mediawiki/core@REL1_44] LinksUpdate: Handle nullable el_to_path column in ExternalLinksUpdate

https://gerrit.wikimedia.org/r/1232577

Change #1232576 merged by jenkins-bot: