Using null as an array offset is deprecated, use an empty string instead in ShellboxClientFactory
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Dec 29 2025, 9:53 PM

Description

https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-mysql-php85/3/consoleFull

13:59:58 460) MediaWiki\Tests\Unit\Shell\ShellboxClientFactoryTest::testIsEnabled with data set "default configured, default service" (array('http://example.com'), null, true)
13:59:58 Using null as an array offset is deprecated, use an empty string instead
13:59:58 
13:59:58 /workspace/src/includes/Shell/ShellboxClientFactory.php:115
13:59:58 /workspace/src/includes/Shell/ShellboxClientFactory.php:50
13:59:58 /workspace/src/tests/phpunit/unit/includes/Shell/ShellboxClientFactoryTest.php:25

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
ShellboxClientFactory: Handle $service being null in getUrl()	mediawiki/core	REL1_45	+1 -2
ShellboxClientFactory: Handle $service being null in getUrl()	mediawiki/core	REL1_44	+1 -2
ShellboxClientFactory: Handle $service being null in getUrl()	mediawiki/core	REL1_43	+1 -2
ShellboxClientFactory: Handle $service being null in getUrl()	mediawiki/core	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned In: T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI

Event Timeline

Reedy created this task.Dec 29 2025, 9:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2025, 9:53 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Dec 29 2025, 9:55 PM

Change #1222631 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] ShellboxClientFactory: Handle $service being null in getUrl()

https://gerrit.wikimedia.org/r/1222631

gerritbot added a project: Patch-For-Review.Jan 2 2026, 11:55 PM

Change #1222631 merged by jenkins-bot:

[mediawiki/core@master] ShellboxClientFactory: Handle $service being null in getUrl()

https://gerrit.wikimedia.org/r/1222631

Maintenance_bot removed a project: Patch-For-Review.Jan 3 2026, 3:30 PM

Change #1222714 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_45] ShellboxClientFactory: Handle $service being null in getUrl()

https://gerrit.wikimedia.org/r/1222714

Change #1222716 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_44] ShellboxClientFactory: Handle $service being null in getUrl()

https://gerrit.wikimedia.org/r/1222716

Change #1222718 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_43] ShellboxClientFactory: Handle $service being null in getUrl()

https://gerrit.wikimedia.org/r/1222718

Reedy closed this task as Resolved.Jan 3 2026, 4:28 PM

Reedy claimed this task.

Change #1222718 merged by jenkins-bot:

[mediawiki/core@REL1_43] ShellboxClientFactory: Handle $service being null in getUrl()

https://gerrit.wikimedia.org/r/1222718

Change #1222716 merged by jenkins-bot:

[mediawiki/core@REL1_44] ShellboxClientFactory: Handle $service being null in getUrl()

https://gerrit.wikimedia.org/r/1222716

Change #1222714 merged by jenkins-bot: