Using null as an array offset is deprecated, use an empty string instead in LanguageCodeTest::testReplaceDeprecatedCodes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Dec 29 2025, 9:49 PM

Description

https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-mysql-php85/3/consoleFull

13:59:58 231) MediaWiki\Tests\Unit\Language\LanguageCodeTest::testReplaceDeprecatedCodes
13:59:58 Using null as an array offset is deprecated, use an empty string instead
13:59:58 
13:59:58 /workspace/src/includes/Language/LanguageCode.php:185
13:59:58 /workspace/src/tests/phpunit/unit/includes/Language/LanguageCodeTest.php:52

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
LanguageCodeTest: Remove unnecessary null assertion	mediawiki/core	REL1_45	+2 -2
LanguageCodeTest: Remove unnecessary null assertion	mediawiki/core	REL1_44	+2 -2
LanguageCodeTest: Remove unnecessary null assertion	mediawiki/core	REL1_43	+2 -2
LanguageCodeTest: Remove unnecessary null assertion	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI
Mentioned Here: rMW55ecf3e215a2: Add new static function LanguageCode::replaceDeprecatedCodes

Event Timeline

Reedy created this task.Dec 29 2025, 9:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2025, 9:49 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Dec 29 2025, 9:54 PM

I don't know if we hit this at runtime, but a test that passes null to something that is documented as needing a string...

	public function testReplaceDeprecatedCodes() {
		$this->assertEquals( 'gsw', LanguageCode::replaceDeprecatedCodes( 'als' ) );
		$this->assertEquals( 'gsw', LanguageCode::replaceDeprecatedCodes( 'gsw' ) );
		$this->assertNull( LanguageCode::replaceDeprecatedCodes( null ) );
	}

	/**
	 * Replace deprecated language codes that were used in previous
	 * versions of MediaWiki to up-to-date, current language codes.
	 * Other values will be returned unchanged.
	 *
	 * @param string $code Old language code
	 * @return string New language code
	 *
	 * @since 1.30
	 */
	public static function replaceDeprecatedCodes( $code ) {
		return self::DEPRECATED_LANGUAGE_CODE_MAPPING[$code] ?? $code;
	}