Page MenuHomePhabricator
Create Task
Maniphest T413577

The float-string "18446744073709551681" is not representable as an int, cast occurred
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-mysql-php85/3/consoleFull

13:59:58 329) MediaWiki\Tests\Parser\SanitizerUnitTest::testDecodeCharReferences with data set "Invalid numbered entity w/ valid truncation (decimal)" ('�', '�')
13:59:58 The float-string "18446744073709551681" is not representable as an int, cast occurred
13:59:58 
13:59:58 /workspace/src/includes/Parser/Sanitizer.php:1308
13:59:58 /workspace/src/includes/Parser/Sanitizer.php:1273
13:59:58 /workspace/src/tests/phpunit/unit/includes/Parser/SanitizerUnitTest.php:19

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Parser: Ignore long user provided int in Sanitizer::decodeCharReferencesmediawiki/coreREL1_45+3 -1
Parser: Ignore long user provided int in Sanitizer::decodeCharReferencesmediawiki/coreREL1_43+3 -1
Parser: Ignore long user provided int in Sanitizer::decodeCharReferencesmediawiki/coreREL1_44+3 -1
Parser: Ignore long user provided int in Sanitizer::decodeCharReferencesmediawiki/coremaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Dec 29 2025, 9:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2025, 9:44 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.5 support board.Dec 29 2025, 9:55 PM
Reedy added a subscriber: cscott.Jan 2 2026, 7:05 PM

Seems this was added to the tests in rMW6153062d482d: Protect against long match length in CHAR_REFS_REGEX.

A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 5 2026, 9:44 AM
gerritbot added a comment.Jan 16 2026, 6:50 PM

Change #1227879 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227879

gerritbot added a project: Patch-For-Review.Jan 16 2026, 6:50 PM
Umherirrender claimed this task.Jan 16 2026, 6:50 PM
gerritbot added a comment.Jan 16 2026, 8:50 PM

Change #1227879 merged by jenkins-bot:

[mediawiki/core@master] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227879

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2026, 9:31 PM
gerritbot added a comment.Jan 16 2026, 10:30 PM

Change #1227923 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_45] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227923

gerritbot added a project: Patch-For-Review.Jan 16 2026, 10:30 PM
gerritbot added a comment.Jan 16 2026, 10:49 PM

Change #1227935 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_44] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227935

gerritbot added a comment.Jan 16 2026, 10:49 PM

Change #1227936 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_43] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227936

Umherirrender closed this task as Resolved.Jan 16 2026, 11:01 PM
Umherirrender removed a project: Patch-For-Review.
gerritbot added a comment.Jan 16 2026, 11:15 PM

Change #1227935 merged by jenkins-bot:

[mediawiki/core@REL1_44] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227935

gerritbot added a comment.Jan 16 2026, 11:16 PM

Change #1227936 merged by jenkins-bot:

[mediawiki/core@REL1_43] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227936

gerritbot added a comment.Jan 16 2026, 11:18 PM

Change #1227923 merged by jenkins-bot:

[mediawiki/core@REL1_45] Parser: Ignore long user provided int in Sanitizer::decodeCharReferences

https://gerrit.wikimedia.org/r/1227923

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits