Page MenuHomePhabricator

Append a tag to edits in which ≥1 Edit Suggestion was visible in the browser viewport
Open, HighPublic

Description

This task involves the work of introducing an initial edit tag that will get appended to all published edits in which ≥1 edit suggestion was visible in the browser viewport.[i]

For now, this initial tag will not include any specificity around what type(s) of edit suggestion(s) was shown or how (if at all) someone engaged with said suggestion.

Later on, we might need to extend this implementation to include both of the above. [ii] Although, for now, let's keep things relatively generic so that we can at least gain some visibility into the sorts of edits people are publishing when a suggestion was visible.

Stories

As someone contributing to and/or curious about Suggestion Mode (and the suggestions that appear within it), I want to be able to see all published edits in which ≥1 edit suggestion was shown so that I can distinguish edits made in the presence of suggestions from edits made without them and begin to understand how this presence affects the type(s) and quality of edits people are publishing.

NOTE: this would will also help enable views/functionality like T410929

Requirements

  1. Introduce a new tag called editsuggestion-visible [iii] that it is applied to edits where ≥1 edit suggestion is visible in the browser viewport [i]
  2. This tag should be visible

Done


i. "Shown" in this context refers to a suggestion that someone, the proxy for which is it entering someone's viewport. See: T412334.
ii. The type(s) of suggestion(s) someone was shown during an edit session and how (if at all) someone engaged with them.
iii. I'm thinking in the future we could extend this naming scheme to be something like editsuggestion-[type]-visible, as did with Edit Checks (https://www.mediawiki.org/wiki/Edit_check/Tags).

Event Timeline

DLynch renamed this task from Append a tag to edits in which ≥1 Edit Suggestion was shown to Append a tag to edits in which ≥1 Edit Suggestion was visible in the browser viewport.Fri, Jan 30, 8:23 PM
DLynch updated the task description. (Show Details)

Change #1236822 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] EditCheck: add instrumentation for checks seen during edit session

https://gerrit.wikimedia.org/r/1236822

Change #1236822 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: add instrumentation for checks seen during edit session

https://gerrit.wikimedia.org/r/1236822

Change #1237606 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.14] EditCheck: add instrumentation for checks seen during edit session

https://gerrit.wikimedia.org/r/1237606

Change #1237606 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.14] EditCheck: add instrumentation for checks seen during edit session

https://gerrit.wikimedia.org/r/1237606

Mentioned in SAL (#wikimedia-operations) [2026-02-09T21:18:27Z] <zabe@deploy2002> Started scap sync-world: Backport for [[gerrit:1238031|Add alias for arwikibooks namespace]], [[gerrit:1237902|Change wgSiteName and wgMetaNamespace for Arabic Wikibooks (ويكي الكتب => ويكي كتب). (T416779)]], [[gerrit:1237606|EditCheck: add instrumentation for checks seen during edit session (T413419 T412334)]]

Mentioned in SAL (#wikimedia-operations) [2026-02-09T21:21:06Z] <zabe@deploy2002> sync-world aborted: Backport for [[gerrit:1238031|Add alias for arwikibooks namespace]], [[gerrit:1237902|Change wgSiteName and wgMetaNamespace for Arabic Wikibooks (ويكي الكتب => ويكي كتب). (T416779)]], [[gerrit:1237606|EditCheck: add instrumentation for checks seen during edit session (T413419 T412334)]] (duration: 02m 38s)

Change #1238033 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.14] Revert^2 "EditCheck: add instrumentation for checks seen during edit session"

https://gerrit.wikimedia.org/r/1238033

Change #1238033 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.14] Revert^2 "EditCheck: add instrumentation for checks seen during edit session"

https://gerrit.wikimedia.org/r/1238033

Mentioned in SAL (#wikimedia-operations) [2026-02-09T23:26:40Z] <zabe@deploy2002> Started scap sync-world: Backport for [[gerrit:1238033|Revert^2 "EditCheck: add instrumentation for checks seen during edit session" (T413419 T412334)]], [[gerrit:1224793|Add MultiTitle to extension list (T404461)]]

Mentioned in SAL (#wikimedia-operations) [2026-02-09T23:51:27Z] <zabe@deploy2002> tbodt, zabe: Backport for [[gerrit:1238033|Revert^2 "EditCheck: add instrumentation for checks seen during edit session" (T413419 T412334)]], [[gerrit:1224793|Add MultiTitle to extension list (T404461)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-02-10T00:06:17Z] <zabe@deploy2002> Finished scap sync-world: Backport for [[gerrit:1238033|Revert^2 "EditCheck: add instrumentation for checks seen during edit session" (T413419 T412334)]], [[gerrit:1224793|Add MultiTitle to extension list (T404461)]] (duration: 39m 37s)

Ryasmeen subscribed.

I am seeing editsuggestion-visible / Edit Check Seen tag when I expand the suggestion card during an edit session. I am not seeing this tag being applied to edit where ≥1 edit suggestion was simply visible in the browser viewport.

Screenshot 2026-02-10 at 12.21.48 PM.png (1×2 px, 274 KB)

Screenshot 2026-02-10 at 12.31.52 PM.png (1×2 px, 589 KB)

I too am seeing Edit check seen appended to a published edit in which I saw an Edit Suggestion [i] when I expected editsuggestion-visible to be the name we use for the tag instead.


i. https://en.wikipedia.org/w/index.php?title=Adolfo_Farsari&diff=1337724137&oldid=1337715839

@ppelberg Ah, I may have misunderstood - I implemented it so that the tag's name is editsuggestion-visible, but what shows on change lists is Edit Check seen. [i]

You can see it listed as such in Special:Tags. This was following the convention I had seen with other edit check tags, like editcheck-tone-shown. I'm happy to change it if need be!

i. I'm also realizing that even if we decide to keep this convention, we should probably change the description to Edit **Suggestion** seen instead.

@Ryasmeen , we're using the definition of "visible" that we've defined in T412334, which is that the suggestion was expanded, so I think the behavior you're seeing is expected. Sorry, all the terms get a bit confusing.

Thank you for walking out this thinking, @medelius. A couple of thoughts in response.

@ppelberg Ah, I may have misunderstood - I implemented it so that the tag's name is editsuggestion-visible, but what shows on change lists is Edit Check seen. [i]

Ah, ok.

You can see it listed as such in Special:Tags. This was following the convention I had seen with other edit check tags, like editcheck-tone-shown. I'm happy to change it if need be!

Mmm, understood.

i. I'm also realizing that even if we decide to keep this convention, we should probably change the description to Edit **Suggestion** seen instead.

+1

Path forward
For the time being, what do you think about making it so the tag is called editsuggestion-seen and the tag name that appears within the UI is Edit Suggestion seen [i]?

...I ask the above mindful, as you helpfully pointed out, that we currently use shown for Checks to mean "seen" in the sense that a Check was both activated and assumed to be seen by someone given that the UX specifies as Check be displayed in someone's viewport.

Change #1239432 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] EditCheck: adjust editsuggestion-seen tag

https://gerrit.wikimedia.org/r/1239432

Change #1239432 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: adjust editsuggestion-seen tag

https://gerrit.wikimedia.org/r/1239432