Background
During discussions on T379066, some bugs were raised regarding how Special:GlobalContributions works for a user who does not have the right to reveal temporary account IPs on all wikis. Such a user should be able to use Special:GlobalContributions and see results from any wikis where they do have the right to reveal IPs.
The bugs were related to the fact that accessing Special:GlobalContributions redirects to a central GlobclContributions wiki, defined in the configuration. (On WMF production, this is metawiki.)
The bugs:
- Accessing Special:GlobalContributions on a wiki where you don't have the right to reveal IP will show you a permission error, even if you have the right somewhere else.
- If you don't have global IP reveal rights, don't have local IP reveal rights at the GlobalContributions central wiki, but do have local IP reveal rights at another wiki, you can't access Special:GlobalContributions at all.
Solution
Since we can't check permissions at all wikis, one way we can solve this is to remove the check for the IP reveal permission from Special:GlobalContributions, as suggested in T379066#10306705.
Instead we can leave checking for the right (and the global preference) until we query for the results. The right is already checked at this point for at each wiki.
Notes
The experience for users with rights only at some wikis should also be improved by T378641: Update copy on Special:GlobalContributions.
