Page MenuHomePhabricator
Create Task
Maniphest T367584

After an appropriate time, drop `_complex_` from ParserOutput serialization
Open, Needs TriagePublic
Actions

Description

Since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1038445 the json serialization format has not required the _complex_ property to be present, as it is redundant with the existing _type_ property.

After an appropriate interval (see https://www.mediawiki.org/wiki/Manual:Parser_cache/Serialization_compatibility#Cleaning_up_old_test_cases) we can remove the backward compatibility code in core's JsonCodec.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
JsonCodec: stop writing backward-compatibility properties for MW 1.39mediawiki/coremaster+7 -7
JsonCodec/ParserCache: Forward-compatibility test casesmediawiki/coreREL1_43+43 -0
JsonCodec/ParserCache: Forward-compatibility test casesmediawiki/coreREL1_44+43 -0
JsonCodec/ParserCache: Forward-compatibility test casesmediawiki/coreREL1_45+43 -0
JsonCodec/ParserCache: Forward-compatibility test casesmediawiki/coremaster+43 -0
Split forward and back compat for JsonCodecmediawiki/coremaster+14 -8
Customize query in gerrit

Event Timeline

cscott created this task.Jun 14 2024, 5:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2024, 5:05 PM
cscott added a comment.Jul 23 2025, 10:00 PM

The https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1038445 patch was included in 1.43. So backCompat is only needed for roll-back compatibility when 1.39 reads JSON files emitted by MW >= 1.43. MW 1.39 is expected to reach end-of-life in November 2025. MW 1.45 isn't going to be released until December 2025, so it should be safe to turn off the 'backCompat' flag in MW 1.45.

gerritbot added a comment.Aug 28 2025, 9:47 PM

Change #1180195 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Split forward and back compat for JsonCodec

https://gerrit.wikimedia.org/r/1180195

gerritbot added a project: Patch-For-Review.Aug 28 2025, 9:47 PM
Michael subscribed.Sep 18 2025, 12:53 PM
gerritbot added a comment.Sep 18 2025, 3:19 PM

Change #1180195 merged by jenkins-bot:

[mediawiki/core@master] Split forward and back compat for JsonCodec

https://gerrit.wikimedia.org/r/1180195

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2025, 3:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 18 2025, 4:00 PM
gerritbot added a comment.Feb 12 2026, 9:07 PM

Change #1239125 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] JsonCodec: stop writing backward-compatibility properties for MW 1.39

https://gerrit.wikimedia.org/r/1239125

gerritbot added a project: Patch-For-Review.Feb 12 2026, 9:08 PM

Change #1239240 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239240

gerritbot added a comment.Feb 17 2026, 11:16 AM

Change #1239240 merged by jenkins-bot:

[mediawiki/core@master] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239240

gerritbot added a comment.Feb 17 2026, 2:19 PM

Change #1239944 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_45] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239944

gerritbot added a comment.Feb 17 2026, 2:24 PM

Change #1239946 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_44] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239946

gerritbot added a comment.Feb 17 2026, 2:25 PM

Change #1239948 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_43] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239948

gerritbot added a comment.Feb 17 2026, 4:49 PM

Change #1239944 merged by jenkins-bot:

[mediawiki/core@REL1_45] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239944

gerritbot added a comment.Feb 17 2026, 7:46 PM

Change #1239946 merged by jenkins-bot:

[mediawiki/core@REL1_44] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239946

gerritbot added a comment.Feb 18 2026, 1:16 AM

Change #1239948 merged by jenkins-bot:

[mediawiki/core@REL1_43] JsonCodec/ParserCache: Forward-compatibility test cases

https://gerrit.wikimedia.org/r/1239948

gerritbot added a comment.Mar 17 2026, 8:58 PM

Change #1239125 merged by jenkins-bot:

[mediawiki/core@master] JsonCodec: stop writing backward-compatibility properties for MW 1.39

https://gerrit.wikimedia.org/r/1239125

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 17 2026, 9:01 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2026, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits