Page MenuHomePhabricator
Create Task
Maniphest T114754

Make error widget for displaying an error in an inspector
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

If generated content contains an error, the error message is displayed in the inspector. As the error message consists of 3 DOM nodes (wrapper, icon, label) and an internal state (expanded, collapsed) it's a good candidate for moving to a separate widget.

Details

SubjectRepoBranchLines +/-
Use new error elementmediawiki/extensions/Scoremaster+2 -6
Use new error elementmediawiki/extensions/Mathmaster+1 -1
Make new error elementmediawiki/extensions/VisualEditormaster+180 -57
Customize query in gerrit

Event Timeline

Tchanders created this task.Oct 6 2015, 1:06 PM
Tchanders claimed this task.
Tchanders raised the priority of this task from to Needs Triage.
Tchanders updated the task description. (Show Details)
Tchanders added a project: VisualEditor.
Tchanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2015, 1:07 PM
Jdforrester-WMF triaged this task as Medium priority.Oct 6 2015, 7:02 PM
Jdforrester-WMF added a project: VisualEditor-EditingTools.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
gerritbot subscribed.Oct 29 2015, 10:15 PM

Change 246787 had a related patch set uploaded (by Tchanders):
Use new error element

https://gerrit.wikimedia.org/r/246787

gerritbot added a project: Patch-For-Review.Oct 29 2015, 10:15 PM

Change 246788 had a related patch set uploaded (by Tchanders):
Use new error element

https://gerrit.wikimedia.org/r/246788

gerritbot added a comment.Oct 29 2015, 10:34 PM

Change 246789 had a related patch set uploaded (by Tchanders):
Make new error element

https://gerrit.wikimedia.org/r/246789

gerritbot added a comment.Oct 29 2015, 10:44 PM

Change 246789 merged by jenkins-bot:
Make new error element

https://gerrit.wikimedia.org/r/246789

gerritbot added a comment.Oct 29 2015, 10:46 PM

Change 246788 merged by jenkins-bot:
Use new error element

https://gerrit.wikimedia.org/r/246788

gerritbot added a comment.Oct 29 2015, 10:46 PM

Change 246787 merged by jenkins-bot:
Use new error element

https://gerrit.wikimedia.org/r/246787

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 29 2015, 11:00 PM
Jdforrester-WMF closed this task as Resolved.Oct 31 2015, 12:07 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits