Differential D89823

Bug 1664298 - Upgrade authenticator-rs to v0.3.0 r?keeler
ClosedPublic
Actions

Authored by • jcj on Sep 10 2020, 9:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 23, 6:26 PM

	Unknown Object (File)
	Mon, Mar 23, 7:34 AM

	Unknown Object (File)
	Sun, Mar 22, 10:31 PM

	Unknown Object (File)
	Sat, Mar 21, 10:20 PM

	Unknown Object (File)
	Mar 12 2026, 5:01 PM

	Unknown Object (File)
	Mar 12 2026, 6:18 AM

	Unknown Object (File)
	Dec 23 2025, 4:35 PM

	Unknown Object (File)
	Dec 23 2025, 4:35 PM

View All 25 Files

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRALecaff97c6a4c: Bug 1664298 - Upgrade authenticator-rs to v0.3.0 r=kjacobs

Bugzilla Bug ID

Summary

https://github.com/mozilla/authenticator-rs/releases/tag/v0.3.0

Major changes:

Move to Rust 2018 edition #125
Remove dependency on boxfnonce #121
Reworked error handling #130
Added a higher-level AuthenticatorService that can use multiple backends #123
Changed the C API to use the new AuthenticatorService #123
Added a Status channel for backends #122
Now obtaining HID report sizes from the descriptors #12
Add authenticator USB and Firmware details to the C API #93

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

• jcj planned changes to this revision.Sep 10 2020, 9:07 PM

• jcj created this revision.

Herald added a project: secure-revision. · View Herald TranscriptSep 10 2020, 9:07 PM

Harbormaster completed remote builds in B238819: Diff 337858.Sep 10 2020, 9:07 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Sep 10 2020, 9:07 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

This is the first big refactor, as in the description. Other than error handling and a new layer of indirection it doesn't really change the logic, however the next versions will, and should be smaller changes. At least until landing CTAP2 protocol support!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2a935f3c0ed3e3e882c16758b10bc6760e161a3

retry: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b813eb4ab478db4b2714ddebeea6e762d1c42472

The uplift looks right. r+ pending resolution on the try weirdness.

This revision is now accepted and ready to land.Sep 10 2020, 11:20 PM

Try 3? https://treeherder.mozilla.org/#/jobs?repo=try&revision=48d0e1854bf88e0cbc3f255759598b22f6732139

Closed by commit rMOZILLACENTRALecaff97c6a4c: Bug 1664298 - Upgrade authenticator-rs to v0.3.0 r=kjacobs (authored by • jcj). · Explain WhySep 11 2020, 4:18 AM

This revision was automatically updated to reflect the committed changes.

• jcj added a commit: rMOZILLACENTRALecaff97c6a4c: Bug 1664298 - Upgrade authenticator-rs to v0.3.0 r=kjacobs.

Revision Contents
Changeset List

Path

Size

third_party/

rust/

authenticator/

.cargo-checksum.json

2 lines

22 lines

5 lines

2 lines

examples/

138 lines

src/

authenticatorservice.rs

624 lines

131 lines

12 lines

96 lines

freebsd/

32 lines

6 lines

20 lines

6 lines

91 lines

31 lines

linux/

37 lines

19 lines

ioctl_aarch64le.rs

4 lines

4 lines

ioctl_mipsbe.rs

4 lines

ioctl_mipsle.rs

4 lines

ioctl_powerpc64le.rs

4 lines

ioctl_powerpcbe.rs

4 lines

4 lines

ioctl_x86_64.rs

4 lines

36 lines

18 lines

macos/

65 lines

3 lines

4 lines

24 lines

107 lines

netbsd/

38 lines

2 lines

21 lines

8 lines

openbsd/

32 lines

2 lines

18 lines

statecallback.rs

162 lines

statemachine.rs

118 lines

stub/

22 lines

18 lines

5 lines

78 lines

113 lines

36 lines

windows/

35 lines

8 lines

20 lines

33 lines

testing/

cross/

powerpc64le-unknown-linux-gnu.Dockerfile

8 lines

x86_64-unknown-linux-gnu.Dockerfile

7 lines

11 lines

boxfnonce/

.cargo-checksum.json

src/

toolkit/

library/

rust/

shared/

2 lines

Diff 337973

Cargo.lock

Loading...

third_party/rust/authenticator/.cargo-checksum.json

Loading...

third_party/rust/authenticator/Cargo.lock

Loading...

third_party/rust/authenticator/Cargo.toml

Loading...

third_party/rust/authenticator/Cross.toml

Loading...

third_party/rust/authenticator/README.md

Loading...

third_party/rust/authenticator/examples/main.rs

Loading...

third_party/rust/authenticator/src/authenticatorservice.rs

Loading...

third_party/rust/authenticator/src/capi.rs

Loading...

third_party/rust/authenticator/src/consts.rs

Loading...

third_party/rust/authenticator/src/errors.rs

Loading...

third_party/rust/authenticator/src/freebsd/device.rs

Loading...

third_party/rust/authenticator/src/freebsd/monitor.rs

Loading...

third_party/rust/authenticator/src/freebsd/transaction.rs

Loading...

third_party/rust/authenticator/src/freebsd/uhid.rs

Loading...

third_party/rust/authenticator/src/hidproto.rs

Loading...

third_party/rust/authenticator/src/lib.rs

Loading...

third_party/rust/authenticator/src/linux/device.rs

Loading...

third_party/rust/authenticator/src/linux/hidraw.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_aarch64le.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_armle.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_mipsbe.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_mipsle.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_powerpc64le.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_powerpcbe.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_x86.rs

Loading...

third_party/rust/authenticator/src/linux/ioctl_x86_64.rs

Loading...

third_party/rust/authenticator/src/linux/monitor.rs

Loading...

third_party/rust/authenticator/src/linux/transaction.rs

Loading...

third_party/rust/authenticator/src/macos/device.rs

Loading...

third_party/rust/authenticator/src/macos/iokit.rs

Loading...

third_party/rust/authenticator/src/macos/monitor.rs

Loading...

third_party/rust/authenticator/src/macos/transaction.rs

Loading...

third_party/rust/authenticator/src/manager.rs

Loading...

third_party/rust/authenticator/src/netbsd/device.rs

Loading...

third_party/rust/authenticator/src/netbsd/monitor.rs

Loading...

third_party/rust/authenticator/src/netbsd/transaction.rs

Loading...

third_party/rust/authenticator/src/netbsd/uhid.rs

Loading...

third_party/rust/authenticator/src/openbsd/device.rs

Loading...

third_party/rust/authenticator/src/openbsd/monitor.rs

Loading...

third_party/rust/authenticator/src/openbsd/transaction.rs

Loading...

third_party/rust/authenticator/src/statecallback.rs

Loading...

third_party/rust/authenticator/src/statemachine.rs

Loading...

third_party/rust/authenticator/src/stub/device.rs

Loading...

third_party/rust/authenticator/src/stub/transaction.rs

Loading...

third_party/rust/authenticator/src/u2fhid-capi.h

Loading...

third_party/rust/authenticator/src/u2fprotocol.rs

Loading...

third_party/rust/authenticator/src/u2ftypes.rs

Loading...

third_party/rust/authenticator/src/util.rs

Loading...

third_party/rust/authenticator/src/windows/device.rs

Loading...

third_party/rust/authenticator/src/windows/monitor.rs

Loading...

third_party/rust/authenticator/src/windows/transaction.rs

Loading...

third_party/rust/authenticator/src/windows/winapi.rs

Loading...

third_party/rust/authenticator/testing/cross/powerpc64le-unknown-linux-gnu.Dockerfile

Loading...

third_party/rust/authenticator/testing/cross/x86_64-unknown-linux-gnu.Dockerfile

Loading...

third_party/rust/authenticator/testing/run_cross.sh

Loading...

third_party/rust/boxfnonce/.cargo-checksum.json

Loading...

third_party/rust/boxfnonce/Cargo.toml

Loading...

third_party/rust/boxfnonce/LICENSE

Loading...

third_party/rust/boxfnonce/README.md

Loading...

third_party/rust/boxfnonce/src/lib.rs

Loading...

third_party/rust/boxfnonce/src/macros.rs

Loading...

third_party/rust/boxfnonce/src/no_send.rs

Loading...

third_party/rust/boxfnonce/src/send.rs

Loading...

third_party/rust/boxfnonce/src/traits.rs

Loading...

toolkit/library/rust/shared/Cargo.toml

Loading...