Differential D71027

Bug 1629761 - Should not invoke attributeChangedCallback for the attribute that is changed during upgrading;
ClosedPublic
Actions

Authored by edgar on Apr 15 2020, 11:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 3, 6:10 AM

	Unknown Object (File)
	Oct 15 2025, 5:22 PM

	Unknown Object (File)
	Sep 25 2024, 9:57 AM

	Unknown Object (File)
	Aug 6 2024, 6:09 AM

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRAL77837af32f02: Bug 1629761 - Should not invoke attributeChangedCallback for the attribute that…
rMOZILLACENTRALa8129abc4c2d: Bug 1629761 - Should not invoke attributeChangedCallback for the attribute that…

Bugzilla Bug ID

Summary

In https://dom.spec.whatwg.org/#handle-attribute-changes, the attributeChangedCallback
reaction is enqueued only if the custom-element-state is customized.

And the assumption of "custom-element-definition is only available on the element whose
custom-element-state is customized" is no longer true after bug 1610054 along with the
spec changings in https://github.com/whatwg/html/pull/5126.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

edgar created this revision.Apr 15 2020, 11:43 AM

Herald added a project: secure-revision. · View Herald TranscriptApr 15 2020, 11:43 AM

Harbormaster completed remote builds in B184081: Diff 260874.Apr 15 2020, 11:43 AM

phab-bot requested review of this revision.Apr 15 2020, 11:43 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

edgar edited the summary of this revision. (Show Details)Apr 15 2020, 12:09 PM

edgar added a reviewer: smaug.

Do we need the patch in branches?

dom/base/Element.cpp
2335	Could you get definition from the data. That is what the method does anyhow https://searchfox.org/mozilla-central/rev/72e3388f74458d369af4f6cdbaeaacb719523b8c/dom/base/Element.cpp#3858,3864

This revision is now accepted and ready to land.Apr 15 2020, 12:46 PM

edgar updated this revision to Diff 260915.Apr 15 2020, 1:31 PM

edgar edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B184116: Diff 260915.Apr 15 2020, 1:31 PM

edgar updated this revision to Diff 260921.Apr 15 2020, 1:34 PM

edgar edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B184120: Diff 260921.Apr 15 2020, 1:34 PM

In D71027#2158465, @smaug wrote:

Do we need the patch in branches?

Yes, at least in beta.

dom/base/Element.cpp
2335	Done.

Closed by commit rMOZILLACENTRALa8129abc4c2d: Bug 1629761 - Should not invoke attributeChangedCallback for the attribute that… (authored by edgar). · Explain WhyApr 15 2020, 4:44 PM

This revision was automatically updated to reflect the committed changes.

edgar added a commit: rMOZILLACENTRALa8129abc4c2d: Bug 1629761 - Should not invoke attributeChangedCallback for the attribute that….

edgar added a commit: rMOZILLACENTRAL77837af32f02: Bug 1629761 - Should not invoke attributeChangedCallback for the attribute that….Apr 19 2020, 9:39 PM

Revision Contents
Changeset List

Path

Size

dom/

base/

CustomElementRegistry.h

2 lines

CustomElementRegistry.cpp

3 lines

114 lines

testing/

web-platform/

tests/

custom-elements/

custom-element-reaction-queue.html

33 lines

Diff 261040

dom/base/CustomElementRegistry.h

Loading...

dom/base/CustomElementRegistry.cpp

Loading...

dom/base/Element.cpp

Loading...

testing/web-platform/tests/custom-elements/custom-element-reaction-queue.html

Loading...