Page MenuHomePhabricator

Bug 1616257 - part 1: Redesign `WSRunScanner::GetWSBoundingParent()` r=m_kato!
ClosedPublic

Authored by masayuki on Feb 21 2020, 6:49 AM.
Tags
None
Referenced Files
F68054863: D63610.1776770805.diff
Mon, Apr 20, 11:26 AM
Unknown Object (File)
Tue, Apr 14, 2:35 PM
Unknown Object (File)
Mon, Apr 13, 2:13 AM
Unknown Object (File)
Sat, Apr 11, 2:54 AM
Unknown Object (File)
Sat, Apr 11, 2:31 AM
Unknown Object (File)
Thu, Apr 2, 7:52 PM
Unknown Object (File)
Thu, Apr 2, 4:29 AM
Unknown Object (File)
Wed, Apr 1, 11:44 AM
Subscribers
None

Details

Summary

Its result has 4 meanings:

  1. an editable block element for container of mScanStartPoint.
  2. a topmost inline editable content for container of mScanStartPoint if there

is no editable block parent.

  1. container of mScanStartPoint if it's a block (either editable or

non-editable).

  1. container of mScanStartPoint if its parent is not editable and a inline

content.

#1, #2 and editable case of #3 make sense because the results are topmost
editable content in current context. On the other hand, non-editable case
of #3 and #4 are caused by unexpected wrong fallback code.

So, let's make it always returns the content in the former meaning and if
the caller needs the latter one, they should use the container by themselves.
Therefore, for making what's the start of the search, this patch also makes
new method take start content instead of hiding mScanStartPoint from the
callers.

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
masayuki edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Feb 25 2020, 8:58 AM