Page MenuHomePhabricator
Differential D5333

Bug 1264177 - Implement FetchEvent.resultingClientId r?edenchuang
ClosedPublic
Actions

Authored by • perry on Sep 7 2018, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 14, 7:51 AM
Unknown Object (File)
Tue, Apr 14, 5:04 AM
Unknown Object (File)
Tue, Apr 14, 12:46 AM
Unknown Object (File)
Fri, Apr 10, 5:08 PM
Unknown Object (File)
Fri, Apr 10, 12:14 PM
Unknown Object (File)
Tue, Apr 7, 8:57 AM
Unknown Object (File)
Mon, Apr 6, 9:01 AM
Unknown Object (File)
Sun, Apr 5, 10:30 PM
View All 49 Files
Subscribers
None

Details

Reviewers
edenchuang
• mrbkap
Commits
Restricted Diffusion Commit
rMOZILLACENTRALc79d1544486a: Bug 1264177 - Implement FetchEvent.resultingClientId r=edenchuang,mrbkap
Restricted Diffusion Commit
rMOZILLACENTRAL6ad8b10cc0d6: Bug 1264177 - Implement FetchEvent.resultingClientId r=edenchuang,mrbkap
Bugzilla Bug ID
1264177
Summary
  • Expose FetchEvent.resultingClientId on non-subresource, non-"report"-destination requests.
  • Delay Clients.get(FetchEvent.resultingClientId) resolution until the resulting client is execution ready.
  • Add WPTs to test for existence of resultingClientId and Clients.get promise resolution values.

Diff Detail

Event Timeline

• perry created this revision.Sep 7 2018, 9:41 PM
Herald added a project: secure-revision. · View Herald TranscriptSep 7 2018, 9:41 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Sep 7 2018, 9:41 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Harbormaster completed remote builds in B8727: Diff 13830.Sep 7 2018, 9:41 PM
• perry requested review of this revision.Sep 7 2018, 9:41 PM
• perry edited the summary of this revision. (Show Details)Sep 7 2018, 9:44 PM
• perry mentioned this in D3517: Bug 1264177 - Implement FetchEvent.resultingClientId.
• perry updated this revision to Diff 29338.Oct 30 2018, 12:10 AM

Revision updated.

Harbormaster completed remote builds in B18115: Diff 29338.Oct 30 2018, 12:10 AM
• perry retitled this revision from Bug 1264177 - Implement FetchEvent.resultingClientId r?asuth to Bug 1264177 - Implement FetchEvent.resultingClientId r?edenchuang.Oct 30 2018, 12:11 AM
• perry edited the summary of this revision. (Show Details)
• perry edited reviewers, added: edenchuang; removed: asuth.
edenchuang accepted this revision.Nov 12 2018, 9:11 AM

LGTM.

dom/clients/manager/ClientSourceParent.cpp
17

Already included in .h, remove this line.

This revision is now accepted and ready to land.Nov 12 2018, 9:11 AM
• perry updated this revision to Diff 34566.Nov 12 2018, 7:31 PM

Bug 1264177 - Implement FetchEvent.resultingClientId r?edenchuang

  • Expose FetchEvent.resultingClientId on non-subresource, non-"report"-destination requests.
  • Delay Clients.get(FetchEvent.resultingClientId) resolution until the resulting client is execution ready.
  • Add WPTs to test for existence of resultingClientId and Clients.get promise resolution values.
Harbormaster completed remote builds in B21107: Diff 34566.Nov 12 2018, 7:31 PM
• perry marked an inline comment as done.Nov 12 2018, 7:31 PM
• perry added a reviewer: • mrbkap.Nov 12 2018, 8:02 PM
• mrbkap accepted this revision.Nov 12 2018, 8:09 PM
Closed by commit rMOZILLACENTRAL6ad8b10cc0d6: Bug 1264177 - Implement FetchEvent.resultingClientId r=edenchuang,mrbkap (authored by • perry). · Explain WhyNov 12 2018, 8:15 PM
This revision was automatically updated to reflect the committed changes.
• perry reopened this revision.Nov 13 2018, 12:33 AM
This revision is now accepted and ready to land.Nov 13 2018, 12:33 AM
• perry updated this revision to Diff 34632.Nov 13 2018, 12:33 AM

Bug 1264177 - Implement FetchEvent.resultingClientId r?edenchuang,mrbkap

  • Expose FetchEvent.resultingClientId on non-subresource, non-"report"-destination requests.
  • Delay Clients.get(FetchEvent.resultingClientId) resolution until the resulting client is execution ready.
  • Add WPTs to test for existence of resultingClientId and Clients.get promise resolution values.
Harbormaster completed remote builds in B21146: Diff 34632.Nov 13 2018, 12:33 AM
• perry added a comment.EditedNov 13 2018, 12:40 AM

Move nsContentUtils::IsNonSubresource request from worker thread to main thread

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3e1f05b6d994175761953effc2db2c07ee08123

• perry requested review of this revision.Nov 13 2018, 2:21 AM
edenchuang accepted this revision.Nov 15 2018, 8:28 AM
This revision is now accepted and ready to land.Nov 15 2018, 8:28 AM
Closed by commit rMOZILLACENTRALc79d1544486a: Bug 1264177 - Implement FetchEvent.resultingClientId r=edenchuang,mrbkap (authored by • perry). · Explain WhyNov 15 2018, 8:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
dom/
clients/
manager/
33 lines
5 lines
13 lines
serviceworkers/
7 lines
1 line
26 lines
7 lines
40 lines
webidl/
2 lines
testing/
web-platform/
tests/
service-workers/
service-worker/
156 lines
23 lines
resources/
64 lines
11 lines

Diff 35902

View Options

dom/clients/manager/ClientManagerService.cpp

Loading...
View Options

dom/clients/manager/ClientSourceParent.h

Loading...
View Options

dom/clients/manager/ClientSourceParent.cpp

Loading...
View Options

dom/serviceworkers/ServiceWorkerEvents.h

Loading...
View Options

dom/serviceworkers/ServiceWorkerEvents.cpp

Loading...
View Options

dom/serviceworkers/ServiceWorkerManager.cpp

Loading...
View Options

dom/serviceworkers/ServiceWorkerPrivate.h

Loading...
View Options

dom/serviceworkers/ServiceWorkerPrivate.cpp

Loading...
View Options

dom/webidl/FetchEvent.webidl

Loading...
View Options

testing/web-platform/tests/service-workers/service-worker/clients-get.https.html

Loading...
View Options

testing/web-platform/tests/service-workers/service-worker/fetch-event.https.html

Loading...
View Options

testing/web-platform/tests/service-workers/service-worker/resources/clients-get-resultingClientId-worker.js

Loading...
View Options

testing/web-platform/tests/service-workers/service-worker/resources/fetch-event-test-worker.js

Loading...
Privacy · Cookies · Legal