Differential D52421

Bug 1594097 - Fix profiler symbolication of local builds on Windows by picking up PR #7 from the profiler-get-symbols repo. r=julienw
ClosedPublic
Actions

Authored by mstange on Nov 8 2019, 10:07 PM.

Details

Reviewers

canaltinova

Commits

rMOZILLACENTRALcfee353480f0: Bug 1594097 - Fix profiler symbolication of local builds on Windows by picking…

Bugzilla Bug ID

1594097

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

mstange created this revision.Nov 8 2019, 10:07 PM

Herald added a project: secure-revision. · View Herald TranscriptNov 8 2019, 10:07 PM

Harbormaster completed remote builds in B133380: Diff 189537.Nov 8 2019, 10:07 PM

phab-bot requested review of this revision.Nov 8 2019, 10:07 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: mixedpuppy. · View Herald TranscriptNov 8 2019, 10:07 PM

mstange added a parent revision: D52286: Bug 1594943 - Keep a set of active workers in ProfilerGetSymbols.jsm so that the workers don't get incorrectly garbage collected. r=julienw.Nov 8 2019, 10:08 PM

I'm a bit concerned that your code in https://github.com/mstange/profiler-get-symbols/pull/7/files hasn't been reviewed by anybody. Could you please have somebody with rust knowledge have a look at that code? Maybe @canaltinova can have a quick look?

Adding Nazim as reviewer: hey Nazim, can you please look at the new code in https://github.com/mstange/profiler-get-symbols/pull/7/files ?
If that looks right, please approve here :) Thanks!

Rust side looks good to me, thanks!

This revision is now accepted and ready to land.Nov 12 2019, 6:51 PM

Thanks!

Closed by commit rMOZILLACENTRALcfee353480f0: Bug 1594097 - Fix profiler symbolication of local builds on Windows by picking… (authored by mstange). · Explain WhyNov 12 2019, 8:03 PM

This revision was automatically updated to reflect the committed changes.

Markus Stange <[email protected]> added a commit: rMOZILLACENTRALcfee353480f0: Bug 1594097 - Fix profiler symbolication of local builds on Windows by picking….

Revision Contents
Changeset List

Path

Size

toolkit/

components/

extensions/

ProfilerGetSymbols.jsm

6 lines

profiler_get_symbols.js

10 lines

Diff 190820

View Options

toolkit/components/extensions/ProfilerGetSymbols.jsm