Page MenuHomePhabricator

Bug 1580576 - Remove an assertion to check <details> element's frame type when reframing. r=emilio
ClosedPublic

Authored by TYLin on Sep 11 2019, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 3, 2:10 PM
Unknown Object (File)
Mar 15 2026, 7:47 PM
Unknown Object (File)
Mar 15 2026, 2:37 PM
Unknown Object (File)
Mar 10 2026, 6:30 AM
Unknown Object (File)
Jan 29 2026, 7:07 PM
Unknown Object (File)
Jan 28 2026, 10:04 AM
Unknown Object (File)
Jan 9 2026, 2:12 PM
Unknown Object (File)
Nov 6 2025, 1:54 PM
Subscribers
None

Details

Summary

If a <details> is a multi-column container, and has a column-span child
inside, aFrame can be ColumnSetWrapper or column-span-wrapper frame (due
to GetInsertionPrevSibling()'s modification). The latter case is handled
by "Situation #5 in WipeContainingBlock(), and can be reproduced by
changing <article> tag to <details> in
testing/web-platform/tests/css/css-multicol/multicol-span-all-dynamic-add-005.html

In any case, aFrame might end up in a frame generated by the <details>
element. I feel the assertion to check frame types might not be very
useful. Let's remove it.

Diff Detail