Page MenuHomePhabricator
Differential D287827

Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon. r=#style,keithamus,jjaschke
ClosedPublic
Actions

Authored by emilio on Mar 15 2026, 8:50 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 16, 11:04 AM
Unknown Object (File)
Thu, Apr 16, 10:59 AM
Unknown Object (File)
Thu, Apr 16, 10:56 AM
Unknown Object (File)
Thu, Apr 16, 10:56 AM
Unknown Object (File)
Thu, Apr 16, 7:56 AM
Unknown Object (File)
Wed, Apr 15, 4:15 PM
Unknown Object (File)
Mon, Apr 13, 4:51 PM
Unknown Object (File)
Mon, Apr 13, 8:31 AM
View All 42 Files
Subscribers
Oriol
reviewbot
tobyp
zrhoffman

Details

Reviewers
keithamus
jjaschke
Group Reviewers
Restricted Project
Commits
rFIREFOXAUTOLAND714d4253e04c: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon.
rFIREFOXAUTOLAND1769a0c24a03: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon.
Bugzilla Bug ID
2023454
Summary

And expose it with the custom select flag enabled.

We need to tweak parsing to avoid parsing it as a fully element-backed
pseudo-element (per spec).

Diff Detail

Event Timeline

emilio created this revision.Mar 15 2026, 8:50 PM
Herald added a project: secure-revision. · View Herald TranscriptMar 15 2026, 8:50 PM
phab-bot published this revision for review.Mar 15 2026, 8:50 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: zrhoffman. · View Herald TranscriptMar 15 2026, 8:50 PM
emilio added a child revision: D287828: Bug 2023450 - Honor CSS display on <select> with appearance: base/base-select. r=#layout,keithamus,jjaschke.Mar 15 2026, 8:50 PM
Harbormaster failed remote builds in B929222: Diff 1224712!Mar 15 2026, 9:00 PM
emilio updated this revision to Diff 1224714.Mar 15 2026, 9:03 PM
Harbormaster failed remote builds in B929224: Diff 1224714!Mar 15 2026, 9:04 PM
emilio updated this revision to Diff 1224734.Mar 15 2026, 10:08 PM
emilio updated this revision to Diff 1224737.
Harbormaster failed remote builds in B929246: Diff 1224734!Mar 15 2026, 10:16 PM
Harbormaster failed remote builds in B929249: Diff 1224737!
keithamus accepted this revision.Mar 16 2026, 9:15 AM
This revision is now accepted and ready to land.Mar 16 2026, 9:15 AM
Herald added a project: needs-testing-tag. · View Herald TranscriptMar 16 2026, 9:15 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

keithamus edited projects, added testing-approved; removed needs-testing-tag.Mar 16 2026, 9:16 AM
emilio updated this revision to Diff 1225000.Mar 16 2026, 9:32 AM
emilio updated this revision to Diff 1225001.
emilio edited the summary of this revision. (Show Details)
Harbormaster failed remote builds in B929466: Diff 1225001!Mar 16 2026, 9:42 AM
Harbormaster failed remote builds in B929465: Diff 1225000!
emilio updated this revision to Diff 1225006.Mar 16 2026, 9:46 AM
keithamus accepted this revision.Mar 16 2026, 9:56 AM
reviewbot added a subscriber: reviewbot.Mar 16 2026, 10:17 AM

Code analysis found 3 defects in diff 1225006:

  • 3 defects found by rustfmt (Mozlint)
WARNING: Found 3 defects (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1225006.

Harbormaster completed remote builds in B929471: Diff 1225006.Mar 16 2026, 10:17 AM
emilio updated this revision to Diff 1225029.Mar 16 2026, 10:19 AM
Harbormaster completed remote builds in B929485: Diff 1225029.Mar 16 2026, 10:52 AM
emilio updated this revision to Diff 1225190.Mar 16 2026, 1:39 PM
Harbormaster completed remote builds in B929625: Diff 1225190.Mar 16 2026, 2:07 PM
Closed by commit rFIREFOXAUTOLAND1769a0c24a03: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon. (authored by emilio, committed by [email protected] <[email protected]>). · Explain WhyMar 16 2026, 7:45 PM
This revision was automatically updated to reflect the committed changes.
[email protected] <[email protected]> added a commit: rFIREFOXAUTOLAND1769a0c24a03: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon..
Herald added a subscriber: tobyp. · View Herald TranscriptMar 16 2026, 7:45 PM
rperta reopened this revision.Mar 16 2026, 8:53 PM
This revision is now accepted and ready to land.Mar 16 2026, 8:53 PM
rperta added a reverting change: rFIREFOXAUTOLANDcf745cdb89c5: Revert "Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon..Mar 16 2026, 8:53 PM
Closed by commit rFIREFOXAUTOLAND714d4253e04c: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon. (authored by emilio, committed by [email protected] <[email protected]>). · Explain WhyMar 17 2026, 3:49 PM
This revision was automatically updated to reflect the committed changes.
[email protected] <[email protected]> added a commit: rFIREFOXAUTOLAND714d4253e04c: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon..
[email protected] <[email protected]> mentioned this in rFIREFOXBETA1769a0c24a03: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon..Mon, Mar 23, 11:35 PM
[email protected] <[email protected]> mentioned this in rFIREFOXBETA714d4253e04c: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon..Mon, Mar 23, 11:39 PM
Oriol added a subscriber: Oriol.Tue, Mar 31, 8:27 PM
Oriol added inline comments.
servo/components/style/gecko/pseudo_element.rs
258

It's technically the same since these flags are a single bit, but I would have used contains() instead of intersects().

[email protected] <[email protected]> mentioned this in rFIREFOXRELEASE1769a0c24a03: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon..Wed, Apr 15, 8:03 PM
[email protected] <[email protected]> mentioned this in rFIREFOXRELEASE714d4253e04c: Bug 2023454 - Rename ::-moz-select-picker-icon to just ::picker-icon..Wed, Apr 15, 8:07 PM

Revision Contents
Changeset List

PathSize
dom/
html/
2 lines
layout/
style/
10 lines
res/
3 lines
servo/
components/
selectors/
10 lines
style/
gecko/
42 lines
48 lines
12 lines
1 line
3 lines
2 lines
testing/
web-platform/
meta/
css/
css-forms/
parsing/
xpcom/
ds/
2 lines

Diff 1226612

View Options

dom/html/HTMLSelectElement.cpp

Loading...
View Options

layout/style/PseudoStyleType.h

Loading...
View Options

layout/style/res/forms.css

Loading...
View Options

servo/components/selectors/parser.rs

Loading...
View Options

servo/components/style/gecko/pseudo_element.rs

Loading...
View Options

servo/components/style/gecko/pseudo_elements.py

Loading...
View Options

servo/components/style/gecko/pseudo_elements.toml

Loading...
View Options

servo/components/style/gecko/wrapper.rs

Loading...
View Options

servo/components/style/style_adjuster.rs

Loading...
View Options

servo/components/style/style_resolver.rs

Loading...
View Options

testing/web-platform/meta/css/css-forms/parsing/picker-icon-pseudo-element.html.ini

Loading...
View Options

xpcom/ds/StaticAtoms.py

Loading...
Privacy · Cookies · Legal