Differential D287776

Bug 2023334 - Don't re-selector match for @starting-style. r=#style!
ClosedPublic
Actions

Authored by emilio on Mar 14 2026, 10:32 AM.

Details

Reviewers

Group Reviewers

Restricted Project
layout-reviewers

Commits

rFIREFOXAUTOLAND8df877ddab77: Bug 2023334 - Don't re-selector match for @starting-style. r=firefox-style…

Bugzilla Bug ID

Summary

We're already matching all @starting-style rules during regular
matching, and we're just ignoring them and adding a flag.

Instead, keep them and filter them during the cascade. This is more
similar to what we'd need to do for an @appearance-base container rule,
and simplifies other things as well.

For that, introduce a RuleCascadeFlags (which for now is just a single
bit), and keep that in the CascadePriority (maybe we should call that
something else, RuleCascadeInfo or something?).

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

emilio created this revision.Mar 14 2026, 10:32 AM

Herald added a project: secure-revision. · View Herald TranscriptMar 14 2026, 10:32 AM

phab-bot published this revision for review.Mar 14 2026, 10:32 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: layout-reviewers. · View Herald TranscriptMar 14 2026, 10:32 AM

Herald added a subscriber: zrhoffman. · View Herald Transcript

Harbormaster completed remote builds in B929028: Diff 1224529.Mar 14 2026, 11:07 AM

emilio updated this revision to Diff 1224545.Mar 14 2026, 11:54 AM

Harbormaster failed remote builds in B929040: Diff 1224545!Mar 14 2026, 12:31 PM

emilio updated this revision to Diff 1224709.Mar 15 2026, 8:49 PM

Harbormaster completed remote builds in B929219: Diff 1224709.Mar 15 2026, 9:26 PM

Yeah, this feels better integrated for sure.

Testing - As per comment in the bug: https://treeherder.mozilla.org/jobs?repo=try&revision=f4b099b50b98422df25a8a310457c9febed7f8be

This revision is now accepted and ready to land.Mar 16 2026, 6:12 PM

Herald added a reviewer: devtools-reviewers. · View Herald TranscriptMar 16 2026, 6:12 PM

This revision now requires review to proceed.Mar 16 2026, 6:12 PM

InspectorUtils change is removing code but preserving behavior.

This revision is now accepted and ready to land.Mar 16 2026, 6:17 PM

Closed by commit rFIREFOXAUTOLAND8df877ddab77: Bug 2023334 - Don't re-selector match for @starting-style. r=firefox-style… (authored by emilio, committed by [email protected] <[email protected]>). · Explain WhyMar 16 2026, 9:33 PM

This revision was automatically updated to reflect the committed changes.

[email protected] <[email protected]> added a commit: rFIREFOXAUTOLAND8df877ddab77: Bug 2023334 - Don't re-selector match for @starting-style. r=firefox-style….

Herald added a subscriber: tobyp. · View Herald TranscriptMar 16 2026, 9:33 PM

[email protected] <[email protected]> mentioned this in rFIREFOXBETA8df877ddab77: Bug 2023334 - Don't re-selector match for @starting-style. r=firefox-style….Mon, Mar 23, 11:36 PM

[email protected] <[email protected]> mentioned this in rFIREFOXRELEASE8df877ddab77: Bug 2023334 - Don't re-selector match for @starting-style. r=firefox-style….Wed, Apr 15, 8:04 PM

Revision Contents
Changeset List

Path

Size

layout/

generic/

3 lines

inspector/

InspectorUtils.cpp

58 lines

style/

ServoStyleSet.h

4 lines

ServoStyleSet.cpp

12 lines

servo/

components/

selectors/

16 lines

style/

applicable_declarations.rs

51 lines

6 lines

custom_properties.rs

8 lines

20 lines

invalidation/

element/

document_state.rs

5 lines

relative_selector.rs

10 lines

state_and_attributes.rs

5 lines

29 lines

properties/

35 lines

declaration_block.rs

1 line

21 lines

rule_tree/

3 lines

26 lines

selector_map.rs

18 lines

servo/

1 line

style_resolver.rs

120 lines

43 lines

17 lines

values/

computed/

8 lines

length_percentage.rs

2 lines

10 lines

ports/

geckolib/

79 lines

Diff 1225929

layout/generic/nsIFrame.cpp

Loading...

layout/inspector/InspectorUtils.cpp

Loading...

layout/style/ServoStyleSet.h

Loading...

layout/style/ServoStyleSet.cpp

Loading...

servo/components/selectors/context.rs

Loading...

servo/components/style/applicable_declarations.rs

Loading...

servo/components/style/context.rs

Loading...

servo/components/style/custom_properties.rs

Loading...

servo/components/style/data.rs

Loading...

servo/components/style/invalidation/element/document_state.rs

Loading...

servo/components/style/invalidation/element/relative_selector.rs

Loading...

servo/components/style/invalidation/element/state_and_attributes.rs

Loading...

servo/components/style/matching.rs

Loading...

servo/components/style/properties/cascade.rs

Loading...

servo/components/style/properties/declaration_block.rs

Loading...

servo/components/style/rule_cache.rs

Loading...

servo/components/style/rule_tree/core.rs

Loading...

servo/components/style/rule_tree/mod.rs

Loading...

servo/components/style/selector_map.rs

Loading...

servo/components/style/servo/animation.rs

Loading...

servo/components/style/style_resolver.rs

Loading...

servo/components/style/stylist.rs

Loading...

servo/components/style/traversal.rs

Loading...

servo/components/style/values/computed/animation.rs

Loading...

servo/components/style/values/computed/length_percentage.rs

Loading...

servo/components/style/values/computed/mod.rs

Loading...

servo/ports/geckolib/glue.rs

Loading...