Bug 2019537 - Fix animations of custom properties with guaranteed-invalid value. r?#style
ClosedPublic
Actions

Authored by Oriol on Feb 26 2026, 11:26 AM.

Details

Reviewers

emilio

Group Reviewers

Restricted Project

Commits

rFIREFOXAUTOLAND9f9e2789650d: Bug 2019537 - Fix animations of custom properties with guaranteed-invalid value.
rFIREFOXAUTOLAND8dad5de04800: Bug 2019537 - Make custom properties animatable in Servo, and fix guaranteed…

Bugzilla Bug ID

2019537

Summary

The main goal of this patch is making custom properties animatable in
Servo. However, it also fixes the Gecko problem that custom properties
set to the guaranteed-invalid value weren't animating correctly.

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

Oriol created this revision.Feb 26 2026, 11:26 AM

Herald added a project: secure-revision. · View Herald TranscriptFeb 26 2026, 11:26 AM

Herald added a subscriber: boris. · View Herald Transcript

phab-bot published this revision for review.Feb 26 2026, 11:28 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: zrhoffman. · View Herald TranscriptFeb 26 2026, 11:28 AM

Looks good!

This revision is now accepted and ready to land.Feb 26 2026, 11:38 AM

Harbormaster completed remote builds in B919514: Diff 1212574.Feb 26 2026, 11:42 AM

Oriol retitled this revision from Bug 2019537 - Fix animations of custom properties with guaranteed-invalid value. r?#style to Bug 2019537 - Make custom properties animatable in Servo, and fix guaranteed-invalid cases in Gecko. r?#style.Feb 26 2026, 11:50 AM

Closed by commit rFIREFOXAUTOLAND8dad5de04800: Bug 2019537 - Make custom properties animatable in Servo, and fix guaranteed… (authored by Oriol). · Explain WhyFeb 26 2026, 12:08 PM

This revision was automatically updated to reflect the committed changes.

Oriol added a commit: rFIREFOXAUTOLAND8dad5de04800: Bug 2019537 - Make custom properties animatable in Servo, and fix guaranteed….

asilaghi reopened this revision.Feb 26 2026, 1:41 PM

This revision is now accepted and ready to land.Feb 26 2026, 1:41 PM

asilaghi added a reverting change: rFIREFOXAUTOLAND599a6adc1792: Revert "Bug 2019537 - Make custom properties animatable in Servo, and fix….Feb 26 2026, 1:41 PM

Oriol updated this revision to Diff 1212888.Feb 26 2026, 5:35 PM

Oriol retitled this revision from Bug 2019537 - Make custom properties animatable in Servo, and fix guaranteed-invalid cases in Gecko. r?#style to Bug 2019537 - Fix animations of custom properties with guaranteed-invalid value. r?#style.

Please check the new changes. Hopefully try won't miss anything this time: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=182288

Now I'm correctly handling initial, unset and inherit. For revert and revert-layer I'm adding a comment like in https://searchfox.org/firefox-main/rev/3c52c9c886f7b0423001cef86abfafcf97f2b90a/servo/components/style/properties/helpers/animated_properties.mako.rs#319-325
However, here I can't make them behave as unset because that would break css/css-cascade/revert-layer-011.html.
Instead I'm reverting from_declaration() to return an Option again.