Paths

Table of Contentst

Differential D280900

Bug 2013141 - Make engines=all be the default. r=#style,oriol
ClosedPublic
Actions

Authored by emilio on Jan 29 2026, 8:08 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Apr 9, 7:58 PM

	Unknown Object (File)
	Thu, Apr 9, 5:33 PM

	Unknown Object (File)
	Thu, Apr 9, 2:25 AM

	Unknown Object (File)
	Tue, Apr 7, 10:03 PM

	Unknown Object (File)
	Sat, Apr 4, 1:49 PM

	Unknown Object (File)
	Fri, Apr 3, 12:33 AM

	Unknown Object (File)
	Thu, Mar 26, 12:18 PM

	Unknown Object (File)
	Thu, Mar 26, 11:33 AM

View All 10 Files

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rFIREFOXAUTOLANDd27042fa137e: Bug 2013141 - Make engines=all be the default. r=Oriol,firefox-style-system…

Bugzilla Bug ID

Summary

I think at this point it is reasonable.

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

emilio created this revision.Jan 29 2026, 8:08 AM

Herald added a project: secure-revision. · View Herald TranscriptJan 29 2026, 8:08 AM

emilio added a child revision: D280901: Bug 2013141 - Remove some now dead python code. r=#style,#layout.Jan 29 2026, 8:08 AM

phab-bot published this revision for review.Jan 29 2026, 8:08 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: zrhoffman. · View Herald TranscriptJan 29 2026, 8:08 AM

Harbormaster completed remote builds in B904518: Diff 1193276.Jan 29 2026, 8:35 AM

My concern is that, when implementing a new property in Gecko, somebody will copy paste from an existing property that is supported in Servo, and will forget to add engines = "gecko". So the new property will also get enabled in Servo.

emilio updated this revision to Diff 1193656.Jan 29 2026, 5:30 PM

In D280900#9731617, @Oriol wrote:

My concern is that, when implementing a new property in Gecko, somebody will copy paste from an existing property that is supported in Servo, and will forget to add engines = "gecko". So the new property will also get enabled in Servo.

Though I guess I can add an internal test in Servo that lists all webexposed properties. So that if people forget engines = "gecko", I will detect it when syncing.

This revision is now accepted and ready to land.Jan 29 2026, 5:42 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Oriol edited projects, added testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.Jan 29 2026, 5:43 PM

Yeah we do have tests to avoid exposing properties accidentally in Gecko (we test that all properties we expose are in our property database).

Harbormaster completed remote builds in B904840: Diff 1193656.Jan 29 2026, 6:03 PM

Closed by commit rFIREFOXAUTOLANDd27042fa137e: Bug 2013141 - Make engines=all be the default. r=Oriol,firefox-style-system… (authored by emilio, committed by [email protected] <[email protected]>). · Explain WhyJan 30 2026, 9:13 PM

This revision was automatically updated to reflect the committed changes.

[email protected] <[email protected]> added a commit: rFIREFOXAUTOLANDd27042fa137e: Bug 2013141 - Make engines=all be the default. r=Oriol,firefox-style-system….

Herald added a subscriber: tobyp. · View Herald TranscriptJan 30 2026, 9:13 PM

[email protected] <[email protected]> mentioned this in rFIREFOXBETAd27042fa137e: Bug 2013141 - Make engines=all be the default. r=Oriol,firefox-style-system….Feb 23 2026, 3:07 PM

[email protected] <[email protected]> mentioned this in rFIREFOXRELEASEd27042fa137e: Bug 2013141 - Make engines=all be the default. r=Oriol,firefox-style-system….Wed, Mar 18, 7:09 PM

Revision Contents
Changeset List

Path

Size

servo/

components/

style/

properties/

4 lines

221 lines

shorthands.toml

62 lines

Diff 1194793

servo/components/style/properties/data.py

Loading...

servo/components/style/properties/longhands.toml

Loading...

servo/components/style/properties/shorthands.toml

Loading...