Page MenuHomePhabricator

Bug 1999100 - Don't clip overflow by default on replaced images. r=#layout
ClosedPublic

Authored by emilio on Dec 2 2025, 3:22 PM.
Referenced Files
Unknown Object (File)
Mon, Apr 13, 11:13 PM
Unknown Object (File)
Sat, Apr 11, 10:02 PM
Unknown Object (File)
Wed, Apr 8, 12:38 AM
Unknown Object (File)
Tue, Apr 7, 1:37 AM
Unknown Object (File)
Fri, Apr 3, 8:54 PM
Unknown Object (File)
Mon, Mar 30, 2:30 PM
Unknown Object (File)
Mon, Mar 30, 2:30 PM
Unknown Object (File)
Mon, Mar 30, 2:27 PM

Event Timeline

emilio created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 2 2025, 3:22 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
emilio updated this revision to Diff 1166319.
emilio retitled this revision from WIP: Bug 1999100 - Don't clip overflow by default on images. to WIP: Bug 1999100 - Don't clip overflow by default on replaced images..
emilio requested review of this revision.Dec 4 2025, 1:13 AM
emilio updated this revision to Diff 1166687.
emilio retitled this revision from WIP: Bug 1999100 - Don't clip overflow by default on replaced images. to Bug 1999100 - Don't clip overflow by default on replaced images. r=#layout.
emilio edited the summary of this revision. (Show Details)
emilio added a reviewer: layout-reviewers.

Code analysis found 4 defects in diff 1166687:

  • 4 defects found by rustfmt (Mozlint)
WARNING: Found 4 defects (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1166687.

Code analysis found 4 defects in diff 1166842:

  • 4 defects found by rustfmt (Mozlint)
WARNING: Found 4 defects (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1166842.

Code analysis found 5 defects in diff 1166854:

  • 1 defect found by stylelint (Mozlint)
  • 4 defects found by rustfmt (Mozlint)
WARNING: Found 4 defects (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1166854.

jwatt added a project: testing-approved.
jwatt added a subscriber: jwatt.
jwatt added inline comments.
layout/generic/nsIFrame.cpp
12313–12318

Very helpful comment.

servo/components/style/values/specified/box.rs
37

Can you add a comment with the syntax?

// <visual-box> || <length [0,∞]>
This revision is now accepted and ready to land.Dec 4 2025, 10:48 AM
This revision is now accepted and ready to land.Dec 8 2025, 3:46 PM
This revision is now accepted and ready to land.Dec 10 2025, 1:39 AM

The analysis task source-test-mozlint-eslint failed, but we could not detect any defect.
Please check this task manually.


If you see a problem in this automated review, please report it here.