Code analysis found 1 defect in diff 1150329:

• 1 defect found by clang-format

You can run this analysis locally with:

• ./mach clang-format -p layout/style/nsChangeHint.h

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1150329.

Code analysis found 1 defect in diff 1150568:

• 1 defect found by clang-format

You can run this analysis locally with:

• ./mach clang-format -p layout/style/nsChangeHint.h

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1150568.

Code analysis found 1 defect in diff 1150621:

• 1 defect found by eslint (Mozlint)

You can run this analysis locally with:

• ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1150621.

I can confirm this works as expected for Typed OM. In particular, for example border-*-width can now reify into a CSSNumericValue even when the computed border style is none or hidden, which matches what the WPT checks for.

Also, it’s nice to see that the upcoming spec change simplifies the implementation rather than making it more complicated.

Let me check a few more details.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

I'll take it.