Bug 1962602 - Give gfxFontGroup::GetMetricsForCSSUnits flags to control whether it should load extra font resources to measure the ZERO or WATER IDEOGRAPH characters. r=#style
ClosedPublic
Actions

Authored by jfkthame on Apr 25 2025, 5:03 PM.

Details

Reviewers

emilio

Group Reviewers

Restricted Project

Commits

rMOZILLACENTRAL06dedc60ea29: Bug 1962602 - Give gfxFontGroup::GetMetricsForCSSUnits flags to control whether…

Bugzilla Bug ID

1962602

Summary

This makes the style system pass flags down to GetMetricsForCSSUnits to specify
whether it needs the 'ch' or 'ic' units, which may trigger downloading additional
font resources.

There should be no change in user-visible behavior, except by observing (e.g. in
the devtools network panel) what resources end up being fetched in an example
like the reporter's.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

jfkthame created this revision.Apr 25 2025, 5:03 PM

Herald added a project: secure-revision. · View Herald TranscriptApr 25 2025, 5:03 PM

phab-bot published this revision for review.Apr 25 2025, 5:03 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: • jgilbert. · View Herald TranscriptApr 25 2025, 5:03 PM

Herald added subscribers: zrhoffman, emilio. · View Herald Transcript

Harbormaster completed remote builds in B782557: Diff 1021152.Apr 25 2025, 5:36 PM

emilio accepted this revision.Apr 26 2025, 11:36 AM

emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).

emilio added inline comments.

layout/style/GeckoBindings.cpp
1306	Same here.
1312	I don't think you need the explicit `bool()` if it's in a conditional fwiw.
servo/components/style/values/computed/font.rs
806	Maybe just pass the flags directly? Or is that not possible for some reason?
servo/components/style/values/computed/mod.rs
367	just `mut flags: QueryFontMetricsFlags` then remove the `let mut flags = flags;` below.

jfkthame marked 3 inline comments as done.Apr 26 2025, 4:19 PM

jfkthame added inline comments.

layout/style/GeckoBindings.cpp
1306	The compiler insists on this one, actually.
servo/components/style/values/computed/font.rs
806	Yeah, will do. (Originally I started just adding individual bools everywhere, and this was left-over from that.)