Page MenuHomePhabricator
Differential D237514

Bug 1946679 - Expose and rename style::value::specified::gecko::IntersectionObserverRootMargin. r=emilio
ClosedPublic
Actions

Authored by steven.novaryo on Feb 10 2025, 5:59 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Apr 10, 1:26 AM
Unknown Object (File)
Mon, Apr 6, 2:02 AM
Unknown Object (File)
Mon, Apr 6, 2:02 AM
Unknown Object (File)
Mon, Apr 6, 2:02 AM
Unknown Object (File)
Mon, Apr 6, 2:02 AM
Unknown Object (File)
Mon, Apr 6, 2:02 AM
Unknown Object (File)
Sun, Apr 5, 7:31 AM
Unknown Object (File)
Sun, Apr 5, 1:59 AM
View All 22 Files
Subscribers
reviewbot
zrhoffman

Details

Reviewers
emilio
Commits
rMOZILLACENTRALe4ef0bdde522: Bug 1946679 - Expose and rename style::value::specified::gecko…
Bugzilla Bug ID
1946679

Diff Detail

Event Timeline

steven.novaryo created this revision.Feb 10 2025, 5:59 AM
Herald added a project: secure-revision. · View Herald TranscriptFeb 10 2025, 5:59 AM
Harbormaster completed remote builds in B753059: Diff 981857.Feb 10 2025, 5:59 AM
phab-bot published this revision for review.Feb 10 2025, 5:59 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: zrhoffman. · View Herald TranscriptFeb 10 2025, 5:59 AM
steven.novaryo edited the summary of this revision. (Show Details)Feb 10 2025, 6:12 AM
emilio requested changes to this revision.Feb 10 2025, 11:19 AM

Looks good but let's rename the module name. Thanks!

servo/components/style/values/specified/common.rs
5 ↗(On Diff #981857)

common is a rather weird name. All other modules are "common". I'd probably call this intersection_observer.rs, and mod intersection_observer, and update the comment here.

This revision now requires changes to proceed.Feb 10 2025, 11:19 AM
steven.novaryo requested review of this revision.Feb 11 2025, 5:25 AM
steven.novaryo updated this revision to Diff 982510.
steven.novaryo edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B753543: Diff 982510.Feb 11 2025, 5:25 AM
reviewbot added a subscriber: reviewbot.Feb 11 2025, 5:49 AM

Code analysis found 1 defect in diff 982510:

  • 1 defect found by file-whitespace (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 982510.

steven.novaryo updated this revision to Diff 982540.Feb 11 2025, 6:28 AM
Harbormaster completed remote builds in B753552: Diff 982540.Feb 11 2025, 6:28 AM
emilio accepted this revision.Feb 12 2025, 2:18 PM
emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.Feb 12 2025, 2:18 PM
steven.novaryo updated this revision to Diff 986253.Feb 18 2025, 6:16 AM
Harbormaster completed remote builds in B756267: Diff 986253.Feb 18 2025, 6:16 AM
emilio updated this revision to Diff 986318.Feb 18 2025, 9:52 AM

rebase

Harbormaster completed remote builds in B756301: Diff 986318.Feb 18 2025, 9:52 AM
Closed by commit rMOZILLACENTRALe4ef0bdde522: Bug 1946679 - Expose and rename style::value::specified::gecko… (authored by steven.novaryo). · Explain WhyFeb 18 2025, 9:59 AM
This revision was automatically updated to reflect the committed changes.
steven.novaryo added a commit: rMOZILLACENTRALe4ef0bdde522: Bug 1946679 - Expose and rename style::value::specified::gecko….

Revision Contents
Changeset List

PathSize
dom/
base/
4 lines
layout/
style/
2 lines
servo/
components/
style/
values/
specified/
18 lines
3 lines
ports/
geckolib/
2 lines
12 lines

Diff 986321

View Options

dom/base/DOMIntersectionObserver.cpp

Loading...
View Options

layout/style/ServoBindings.toml

Loading...
View Options

servo/components/style/values/specified/gecko.rs

Loading...
View Options

servo/components/style/values/specified/intersection_observer.rs

Loading...
View Options

servo/components/style/values/specified/mod.rs

Loading...
View Options

servo/ports/geckolib/cbindgen.toml

Loading...
View Options

servo/ports/geckolib/glue.rs

Loading...
Privacy · Cookies · Legal