Page MenuHomePhabricator
Differential D220144

Backed out changeset e90d4466e409 (Bug 1900622)
ClosedPublic
Actions

Authored by ajakobi on Aug 26 2024, 4:02 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 9, 4:36 AM
Unknown Object (File)
Thu, Apr 9, 2:27 AM
Unknown Object (File)
Wed, Apr 8, 2:24 PM
Unknown Object (File)
Wed, Apr 8, 5:08 AM
Unknown Object (File)
Sun, Apr 5, 10:58 PM
Unknown Object (File)
Sun, Apr 5, 10:57 PM
Unknown Object (File)
Sun, Apr 5, 10:57 PM
Unknown Object (File)
Sun, Apr 5, 9:38 PM
View All 21 Files
Subscribers
None

Details

Reviewers
botond
tthibaud
Group Reviewers
android-reviewers
Commits
rMOZILLACENTRALbef0c84e402b: Backed out changeset e90d4466e409 (Bug 1900622) r=botond,android-reviewers…
Bugzilla Bug ID
1900622
Summary

Back out due to regression found by QA in comment #21.

Diff Detail

Event Timeline

ajakobi planned changes to this revision.Aug 26 2024, 4:02 PM
ajakobi created this revision.
Herald added a project: secure-revision. · View Herald TranscriptAug 26 2024, 4:02 PM
Harbormaster completed remote builds in B695325: Diff 905680.Aug 26 2024, 4:02 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Aug 26 2024, 4:02 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
ajakobi requested review of this revision.Aug 26 2024, 4:03 PM
ajakobi retitled this revision from WIP: Backed out changeset e90d4466e409 (Bug 1900622) to Backed out changeset e90d4466e409 (Bug 1900622).
ajakobi added a reviewer: botond.
Herald added a reviewer: android-reviewers. · View Herald TranscriptAug 26 2024, 4:04 PM
botond accepted this revision.Aug 26 2024, 4:04 PM
botond added a project: testing-exception-unchanged (Doesn't change behavior for users).

Testing comment: reverting to a previous state

tthibaud accepted this revision.Aug 27 2024, 9:47 AM
This revision is now accepted and ready to land.Aug 27 2024, 9:47 AM
Closed by commit rMOZILLACENTRALbef0c84e402b: Backed out changeset e90d4466e409 (Bug 1900622) r=botond,android-reviewers… (authored by ajakobi). · Explain WhyAug 27 2024, 9:55 AM
This revision was automatically updated to reflect the committed changes.
ajakobi added a commit: rMOZILLACENTRALbef0c84e402b: Backed out changeset e90d4466e409 (Bug 1900622) r=botond,android-reviewers….

Revision Contents
Changeset List

PathSize
mobile/
android/
android-components/
components/
browser/
engine-gecko/
src/
main/
java/
mozilla/
components/
browser/
engine/
gecko/
4 lines
state/
src/
main/
java/
mozilla/
components/
browser/
state/
action/
2 lines
engine/
6 lines
state/
2 lines
concept/
engine/
src/
main/
java/
mozilla/
components/
concept/
engine/
5 lines
feature/
toolbar/
src/
main/
java/
mozilla/
components/
feature/
toolbar/
21 lines
test/
java/
mozilla/
components/
feature/
toolbar/
36 lines

Diff 906030

View Options

mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt

Loading...
View Options

mobile/android/android-components/components/browser/state/src/main/java/mozilla/components/browser/state/action/BrowserAction.kt

Loading...
View Options

mobile/android/android-components/components/browser/state/src/main/java/mozilla/components/browser/state/engine/EngineObserver.kt

Loading...
View Options

mobile/android/android-components/components/browser/state/src/main/java/mozilla/components/browser/state/state/ContentState.kt

Loading...
View Options

mobile/android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineSession.kt

Loading...
View Options

mobile/android/android-components/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarBehaviorController.kt

Loading...
View Options

mobile/android/android-components/components/feature/toolbar/src/test/java/mozilla/components/feature/toolbar/ToolbarBehaviorControllerTest.kt

Loading...
Privacy · Cookies · Legal