Bug 1874050 - Share more memory in custom property storage. r=dshin,#style,#layout
ClosedPublic
Actions

Authored by emilio on Jan 11 2024, 6:33 PM.

Details

Reviewers

Group Reviewers

Restricted Project
layout-reviewers

Commits

rMOZILLACENTRAL7a81660943a3: Bug 1874050 - Share more memory in custom property storage. r=dshin

Bugzilla Bug ID

1874050

Summary

This implements a similar optimization as WebKit's, see the bug comment.
This should be specially useful for sites with lots of custom
properties.

This is a high-confidence win on this speedometer subtest:

1.9x faster in style updates.
4.2x faster in layout object destruction (we no longer free the huge custom properties map).
Also speeds up paint and layout a bit, probably from less memory churn.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 615699
Build 713928: arc lint + arc unit

Event Timeline

emilio created this revision.Jan 11 2024, 6:33 PM

Herald added a project: secure-revision. · View Herald TranscriptJan 11 2024, 6:33 PM

Herald added a subscriber: boris. · View Herald Transcript

Harbormaster completed remote builds in B615069: Diff 808164.Jan 11 2024, 6:33 PM

phab-bot published this revision for review.Jan 11 2024, 6:33 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: zrhoffman. · View Herald TranscriptJan 11 2024, 6:33 PM

bgrins added a subscriber: bgrins.Jan 11 2024, 6:37 PM

bgrins added inline comments.

servo/components/style/custom_properties_map.rs
28	Is this comment and bug link out of date now? It seems like the code is using the fixed version in https://github.com/bluss/indexmap/issues/153#issuecomment-1678106160.

Remove dependency on indexmap update

Harbormaster completed remote builds in B615176: Diff 808293.Jan 11 2024, 10:38 PM

emilio marked an inline comment as done.Jan 12 2024, 5:26 PM

dshin accepted this revision as: dshin.Jan 12 2024, 5:49 PM

dshin added inline comments.

servo/components/style/custom_properties_map.rs
64	Breaking 255 ancestor limit is probably hard/uncommon, but doesn't seem... impossible

This revision is now accepted and ready to land.Jan 12 2024, 5:49 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!