Bug 1858305 - Update cssparser r=#supply-chain-reviewers,#style
ClosedPublic
Actions

Authored by zrhoffman on Nov 14 2023, 1:49 PM.

Details

Reviewers

Group Reviewers

Restricted Project
Restricted Project

Commits

rMOZILLACENTRAL96d0600a10ad: Bug 1858305 - Update cssparser r=firefox-style-system-reviewers,emilio

Bugzilla Bug ID

1858305

Summary

This replaces TokenSerializationType with
TokenSerializationTypeVariants, which will allow allocating a new
ComputedValue without parsing it (see D193549).

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 596958
Build 695098: arc lint + arc unit

Event Timeline

zrhoffman planned changes to this revision.Nov 14 2023, 1:49 PM

zrhoffman created this revision.

Herald added a project: secure-revision. · View Herald TranscriptNov 14 2023, 1:49 PM

Harbormaster completed remote builds in B596652: Diff 786647.Nov 14 2023, 1:49 PM

zrhoffman added a child revision: D193548: Bug 1858305 - Rewrite use of deprecated function TokenSerializationType::nothing() r=fredw,zsun,#style.Nov 14 2023, 1:49 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 14 2023, 1:49 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

zrhoffman added a child revision: D193549: Bug 1858305 - Store ComputedPropertyValue without parsing r=zsun,fredw,#style.Nov 14 2023, 8:44 PM

zrhoffman requested review of this revision.Nov 14 2023, 8:44 PM

zrhoffman updated this revision to Diff 786858.

zrhoffman retitled this revision from WIP: Bug 1858305 - Update cssparser r=#supply-chain-reviewers,#style to Bug 1858305 - Update cssparser r=#supply-chain-reviewers,#style.

zrhoffman edited the summary of this revision. (Show Details)

zrhoffman added reviewers: Restricted Project, Restricted Project.

Harbormaster completed remote builds in B596784: Diff 786858.Nov 14 2023, 8:44 PM

Code analysis found 7 defects in diff 786858:

7 defects found by source-test-vendor-rust

IMPORTANT: Found 7 defects (error level) that must be fixed before landing.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 786858.

zrhoffman updated this revision to Diff 786864.Nov 14 2023, 9:04 PM

Harbormaster completed remote builds in B596788: Diff 786864.Nov 14 2023, 9:04 PM

emilio accepted this revision.Nov 14 2023, 9:21 PM

This revision is now accepted and ready to land.Nov 14 2023, 9:21 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!