This also simplifies ScrollbarActivity, and removes some attributes that
aren't looked up while at it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Build Status
Buildable 598708 Build 696851: arc lint + arc unit
Event Timeline
Comment Actions
This is super cool since we can remove one nsARefreshObserver!
Overall looks great other than the changes in nsSliderFrame.cpp. Though I am not sure what the purpose of changing nsGkAtoms::active state is there, there's a comment by the original change author:
Setting [active] attribute needed only in two cases:
- After warp slider to current mouse position after left button press on a
scroolbar (scroll-to-click). Also thumb can be dragged to new position until
button isn't released [1].
- Firefox doesn't change thumb's state to :active when you drag them by the
right mouse button (instead of the left button).
I did a quick test about 1, in such case the scroll thumb style isn't changed on the latest nightly so I guess it's been regressed at some point? If you think it's a bug, can you file a new bug for the issue? Thanks!
| servo/components/style/custom_properties.rs | ||
|---|---|---|
| 544–554 | This creates a duplicate definition of int_ms. | |