Page MenuHomePhabricator
Differential D191615

Bug 1857674 - Reuse is_root_element from style builder r=fredw,#style
ClosedPublic
Actions

Authored by zrhoffman on Oct 23 2023, 8:17 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Apr 7, 2:11 PM
Unknown Object (File)
Nov 13 2025, 12:25 PM
Unknown Object (File)
Oct 15 2025, 11:22 PM
Unknown Object (File)
Aug 5 2025, 11:53 PM
Unknown Object (File)
Aug 5 2025, 11:32 AM
Unknown Object (File)
Aug 2 2025, 2:15 AM
Unknown Object (File)
Aug 1 2025, 11:18 AM
Unknown Object (File)
Jul 29 2025, 3:32 AM
View All 34 Files
Subscribers
emilio

Details

Reviewers
fredw
emilio
Group Reviewers
Restricted Project
Commits
rMOZILLACENTRAL24931abca0a6: Bug 1857674 - Reuse is_root_element from style builder r=emilio
Bugzilla Bug ID
1857674
Summary

Depends on D191161

Diff Detail

Event Timeline

zrhoffman created this revision.Oct 23 2023, 8:17 AM
Herald added a project: secure-revision. · View Herald TranscriptOct 23 2023, 8:17 AM
Harbormaster completed remote builds in B589729: Diff 778334.Oct 23 2023, 8:17 AM
zrhoffman added a child revision: D191616: Bug 1857674 - Reuse more fields from the computed context r=fredw,#style,#animation.Oct 23 2023, 8:17 AM
phab-bot published this revision for review.Oct 23 2023, 8:18 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptOct 23 2023, 8:18 AM
zrhoffman updated this revision to Diff 778348.Oct 23 2023, 8:29 AM
zrhoffman edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B589739: Diff 778348.Oct 23 2023, 8:29 AM
emilio accepted this revision as: emilio.Oct 23 2023, 10:30 AM
emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).
emilio added inline comments.
servo/components/style/custom_properties.rs
1256–1257

You can just remove this argument right?

This revision is now accepted and ready to land.Oct 23 2023, 10:30 AM
zrhoffman updated this revision to Diff 778672.Oct 23 2023, 5:03 PM
zrhoffman edited the summary of this revision. (Show Details)
zrhoffman marked an inline comment as done.
Harbormaster completed remote builds in B589972: Diff 778672.Oct 23 2023, 5:03 PM
zrhoffman added inline comments.Oct 23 2023, 5:04 PM
servo/components/style/custom_properties.rs
1256–1257

Oops, argument removed.

Closed by commit rMOZILLACENTRAL24931abca0a6: Bug 1857674 - Reuse is_root_element from style builder r=emilio (authored by zrhoffman). · Explain WhyOct 23 2023, 5:16 PM
This revision was automatically updated to reflect the committed changes.
zrhoffman added a commit: rMOZILLACENTRAL24931abca0a6: Bug 1857674 - Reuse is_root_element from style builder r=emilio.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
18 lines93%
Loading...
properties/
3 lines97%
Loading...
2 lines87%
Loading...
values/
computed/
5 lines82%
Loading...

Diff 778686

View Options

servo/components/style/custom_properties.rs

Loading...
View Options

servo/components/style/properties/cascade.rs

Loading...
View Options

servo/components/style/properties/declaration_block.rs

Loading...
View Options

servo/components/style/values/computed/mod.rs

Loading...
Privacy · Cookies · Legal