Page MenuHomePhabricator
Differential D190252

Bug 1857398 - [css-properties-values-api] Support ToCss for ComputedValue r=fredw,zsun,#style,#layout
ClosedPublic
Actions

Authored by zrhoffman on Oct 6 2023, 6:08 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 9, 7:28 AM
Unknown Object (File)
Thu, Apr 9, 7:28 AM
Unknown Object (File)
Wed, Apr 8, 4:25 AM
Unknown Object (File)
Tue, Apr 7, 2:59 PM
Unknown Object (File)
Mar 7 2026, 4:44 PM
Unknown Object (File)
Nov 13 2025, 12:13 PM
Unknown Object (File)
Oct 14 2025, 5:25 PM
Unknown Object (File)
Aug 5 2025, 11:39 PM
View All 37 Files
Subscribers
emilio

Details

Reviewers
fredw
zsun
Group Reviewers
Restricted Project
layout-reviewers
Commits
rMOZILLACENTRALee84d6e6a073: Bug 1857398 - [css-properties-values-api] Support ToCss for ComputedValue…
Bugzilla Bug ID
1857398
Summary

Depends on D190251

Diff Detail

Event Timeline

zrhoffman created this revision.Oct 6 2023, 6:08 AM
Herald added a project: secure-revision. · View Herald TranscriptOct 6 2023, 6:08 AM
Harbormaster completed remote builds in B584639: Diff 772330.Oct 6 2023, 6:08 AM
zrhoffman added a child revision: D190253: Bug 1846632 - [css-properties-values-api] Store ComputedValue ToCss result r=fredw,zsun,#style,#layout.Oct 6 2023, 6:08 AM
phab-bot published this revision for review.Oct 6 2023, 6:08 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptOct 6 2023, 6:08 AM
fredw accepted this revision.Oct 6 2023, 6:52 AM
fredw added inline comments.
servo/components/style/properties_and_values/syntax/mod.rs
160 ↗(On Diff #772330)

Is this function going to be used elsewhere than List::to_css? If not I would just move that code into List::to_css.

From the function name, I would expect Multiplier. separator() to just return a comma (without space). If instead put inline in List::to_css with the comment linking to the cssom spec (see below) I think it's much clearer why the space is added.

servo/components/style/properties_and_values/value.rs
67

Maybe add a comment linking to https://drafts.csswg.org/cssom-1/#serialize-a-comma-separated-list ?

This revision is now accepted and ready to land.Oct 6 2023, 6:52 AM
Herald added a project: needs-testing-tag. · View Herald TranscriptOct 6 2023, 6:52 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

fredw mentioned this in D190253: Bug 1846632 - [css-properties-values-api] Store ComputedValue ToCss result r=fredw,zsun,#style,#layout.Oct 6 2023, 7:10 AM
zrhoffman updated this revision to Diff 772826.Oct 7 2023, 9:21 AM
zrhoffman edited the summary of this revision. (Show Details)
zrhoffman marked 2 inline comments as done.
Harbormaster completed remote builds in B585046: Diff 772826.Oct 7 2023, 9:21 AM
zrhoffman edited projects, added testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.Oct 7 2023, 9:23 AM
zrhoffman added inline comments.
servo/components/style/properties_and_values/syntax/mod.rs
160 ↗(On Diff #772330)

Is this function going to be used elsewhere than List::to_css? If not I would just move that code into List::to_css.

Moved that code into List::to_css.

From the function name, I would expect Multiplier. separator() to just return a comma (without space). If instead put inline in List::to_css with the comment linking to the cssom spec (see below) I think it's much clearer why the space is added.

Added comments linking to the CSSOM spec.

Closed by commit rMOZILLACENTRALee84d6e6a073: Bug 1857398 - [css-properties-values-api] Support ToCss for ComputedValue… (authored by zrhoffman). · Explain WhyOct 7 2023, 9:39 AM
This revision was automatically updated to reflect the committed changes.
zrhoffman added a commit: rMOZILLACENTRALee84d6e6a073: Bug 1857398 - [css-properties-values-api] Support ToCss for ComputedValue….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
properties_and_values/
37 lines78%
Loading...

Diff 772834

View Options

servo/components/style/properties_and_values/value.rs

Loading...
Privacy · Cookies · Legal