Differential D189521

Bug 1855730: Move `line-height` from text to font style struct. r=#layout-reviewers
ClosedPublic
Actions

Authored by dshin on Sep 28 2023, 3:55 PM.

Details

Reviewers

emilio

Group Reviewers

layout-reviewers

Commits

rMOZILLACENTRAL945dd71f0ac0: Bug 1855730: Move `line-height` from text to font style struct. r=emilio

Bugzilla Bug ID

1855730

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 582531
Build 680473: arc lint + arc unit

Event Timeline

dshin created this revision.Sep 28 2023, 3:55 PM

Herald added a project: secure-revision. · View Herald TranscriptSep 28 2023, 3:55 PM

Harbormaster completed remote builds in B581993: Diff 769170.Sep 28 2023, 3:55 PM

phab-bot published this revision for review.Sep 28 2023, 3:55 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptSep 28 2023, 3:55 PM

emilio accepted this revision as: emilio.Sep 28 2023, 4:29 PM

emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).

This revision is now accepted and ready to land.Sep 28 2023, 4:29 PM

Closed by commit rMOZILLACENTRAL945dd71f0ac0: Bug 1855730: Move `line-height` from text to font style struct. r=emilio (authored by dshin). · Explain WhySep 28 2023, 9:31 PM

This revision was automatically updated to reflect the committed changes.

dshin added a commit: rMOZILLACENTRAL945dd71f0ac0: Bug 1855730: Move `line-height` from text to font style struct. r=emilio.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

layout/

generic/

ReflowInput.cpp

4 lines

96%

nsLineLayout.cpp

8 lines

98%

style/

ServoBindings.toml

2 lines

nsComputedDOMStyle.cpp

2 lines

86%

nsStyleStruct.h

2 lines

96%

nsStyleStruct.cpp

8 lines

93%

servo/

components/

style/

properties/

longhands/

font.mako.rs

11 lines

inherited_text.mako.rs

11 lines

properties.mako.rs

2 lines

shorthands/

font.mako.rs

2 lines

style_adjuster.rs

4 lines

97%

values/

computed/

font.rs

28 lines

72%

mod.rs

4 lines

80%

text.rs

31 lines

62%

generics/

font.rs

47 lines

82%

text.rs

47 lines

84%

specified/

font.rs

57 lines

80%

mod.rs

4 lines

79%

text.rs

60 lines

69%

Diff 769355

View Options

layout/generic/ReflowInput.cpp

View Options

layout/generic/nsLineLayout.cpp

View Options

layout/style/ServoBindings.toml

View Options

layout/style/nsComputedDOMStyle.cpp

View Options

layout/style/nsStyleStruct.h

View Options

layout/style/nsStyleStruct.cpp

View Options

servo/components/style/properties/longhands/font.mako.rs

View Options

servo/components/style/properties/longhands/inherited_text.mako.rs

View Options

servo/components/style/properties/properties.mako.rs

View Options

servo/components/style/properties/shorthands/font.mako.rs

View Options

servo/components/style/style_adjuster.rs

View Options

servo/components/style/values/computed/font.rs

View Options

servo/components/style/values/computed/mod.rs

View Options

servo/components/style/values/computed/text.rs

View Options

servo/components/style/values/generics/font.rs

View Options

servo/components/style/values/generics/text.rs

View Options

servo/components/style/values/specified/font.rs

View Options

servo/components/style/values/specified/mod.rs

View Options

servo/components/style/values/specified/text.rs

Bug 1855730: Move `line-height` from text to font style struct. r=#layout-reviewersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 769355

layout/generic/ReflowInput.cpp

layout/generic/nsLineLayout.cpp

layout/style/ServoBindings.toml

layout/style/nsComputedDOMStyle.cpp

layout/style/nsStyleStruct.h

layout/style/nsStyleStruct.cpp

servo/components/style/properties/longhands/font.mako.rs

servo/components/style/properties/longhands/inherited_text.mako.rs

servo/components/style/properties/properties.mako.rs

servo/components/style/properties/shorthands/font.mako.rs

servo/components/style/style_adjuster.rs

servo/components/style/values/computed/font.rs

servo/components/style/values/computed/mod.rs

servo/components/style/values/computed/text.rs

servo/components/style/values/generics/font.rs

servo/components/style/values/generics/text.rs

servo/components/style/values/specified/font.rs

servo/components/style/values/specified/mod.rs

servo/components/style/values/specified/text.rs

Bug 1855730: Move `line-height` from text to font style struct. r=#layout-reviewers
ClosedPublic
Actions

Revision Contents
Changeset List