Differential D189454

Bug 1855622 - Upgrade rayon-core to 1.12.0.
ClosedPublic
Actions

Authored by glandium on Sep 28 2023, 6:10 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, Mar 25, 5:24 PM

	Unknown Object (File)
	Sun, Mar 22, 4:37 PM

	Unknown Object (File)
	Sun, Mar 22, 5:02 AM

	Unknown Object (File)
	Feb 22 2026, 12:08 AM

	Unknown Object (File)
	Dec 16 2025, 9:18 PM

	Unknown Object (File)
	Nov 17 2025, 7:51 PM

	Unknown Object (File)
	Nov 9 2025, 9:09 PM

	Unknown Object (File)
	Oct 15 2025, 8:29 AM

View All 35 Files

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rMOZILLACENTRAL42828cfcc07d: Bug 1855622 - Upgrade rayon-core to 1.12.0. r=emilio,supply-chain-reviewers

Bugzilla Bug ID

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 582543
Build 680485: arc lint + arc unit

Event Timeline

glandium created this revision.Sep 28 2023, 6:10 AM

Herald added a project: secure-revision. · View Herald TranscriptSep 28 2023, 6:10 AM

Harbormaster completed remote builds in B581776: Diff 768912.Sep 28 2023, 6:10 AM

phab-bot published this revision for review.Sep 28 2023, 6:10 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2023, 6:10 AM

glandium added inline comments.Sep 28 2023, 6:34 AM

third_party/rust/rayon-core/src/lib.rs
558	mmmm clean_up_use_current_thread is not in 1.12.0... @emilio, would it be ok to remove the call from StyleThreadPool::shutdown, or should we keep the current version?

emilio accepted this revision.Sep 28 2023, 7:41 AM

emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).

emilio added inline comments.

third_party/rust/rayon-core/src/lib.rs
558	If CI doesn't complain I'd go ahead and just remove the call. It causes a leak of an object in main-thread TLS storage, but we only shut down the style pool at the end of the process lifetime so it's not a huge deal.

glandium updated this revision to Diff 768934.Sep 28 2023, 7:46 AM

Herald added a subscriber: zrhoffman. · View Herald TranscriptSep 28 2023, 7:46 AM

Harbormaster completed remote builds in B581794: Diff 768934.Sep 28 2023, 7:46 AM

emilio added inline comments.Sep 28 2023, 7:53 AM

Cargo.toml
137	These changes should probably be in another phab revision.

glandium added inline comments.Sep 28 2023, 8:04 AM

Cargo.toml
137	they aren't in this one, it's the byproduct of a local rebase and appears in the interdiff because phabricator is not that smart.

bholley accepted this revision as: Restricted Project.Sep 28 2023, 5:02 PM

This revision is now accepted and ready to land.Sep 28 2023, 5:02 PM

Closed by commit rMOZILLACENTRAL42828cfcc07d: Bug 1855622 - Upgrade rayon-core to 1.12.0. r=emilio,supply-chain-reviewers (authored by glandium). · Explain WhySep 29 2023, 12:18 AM

This revision was automatically updated to reflect the committed changes.

glandium added a commit: rMOZILLACENTRAL42828cfcc07d: Bug 1855622 - Upgrade rayon-core to 1.12.0. r=emilio,supply-chain-reviewers.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

-

-

3 lines

-

-

servo/

components/

style/

global_style_data.rs

3 lines

100%

Loading...

supply-chain/

4 lines

-

-

5 lines

-

-

third_party/

rust/

rayon-core/

.cargo-checksum.json

2 lines

-

-

12 lines

-

-

2 lines

-

-

src/

broadcast/

5 lines

-

-

23 lines

-

-

168 lines

90%

Loading...

79 lines

52%

Loading...

-

-

160 lines

78%

Loading...

scope/

116 lines

87%

Loading...

sleep/

4 lines

100%

Loading...

95 lines

100%

Loading...

thread_pool/

33 lines

100%

Loading...

4 lines

-

-

tests/

scoped_threadpool.rs

2 lines

-

-

use_current_thread.rs

57 lines

-

-

Diff 769437

Cargo.lock

Loading...

Cargo.toml

Loading...

servo/components/style/global_style_data.rs

Loading...

supply-chain/config.toml

Loading...

supply-chain/imports.lock

Loading...

third_party/rust/rayon-core/.cargo-checksum.json

Loading...

third_party/rust/rayon-core/Cargo.toml

Loading...

third_party/rust/rayon-core/README.md

Loading...

third_party/rust/rayon-core/src/broadcast/mod.rs

Loading...

third_party/rust/rayon-core/src/broadcast/test.rs

Loading...

third_party/rust/rayon-core/src/latch.rs

Loading...

third_party/rust/rayon-core/src/lib.rs

Loading...

third_party/rust/rayon-core/src/log.rs

Loading...

third_party/rust/rayon-core/src/registry.rs

Loading...

third_party/rust/rayon-core/src/scope/mod.rs

Loading...

third_party/rust/rayon-core/src/sleep/counters.rs

Loading...

third_party/rust/rayon-core/src/sleep/mod.rs

Loading...

third_party/rust/rayon-core/src/thread_pool/mod.rs

Loading...

third_party/rust/rayon-core/src/thread_pool/test.rs

Loading...

third_party/rust/rayon-core/tests/scoped_threadpool.rs

Loading...

third_party/rust/rayon-core/tests/use_current_thread.rs

Loading...