Differential D188216

Bug 1851370 - Vendor cssparser-color into Gecko r=emilio
ClosedPublic
Actions

Authored by tlouw on Sep 14 2023, 8:04 AM.

Details

Reviewers

emilio

Commits

rMOZILLACENTRAL042192d18265: Bug 1851370 - Vendor cssparser-color into Gecko r=emilio

Bugzilla Bug ID

1851370

Summary

To increase the integration between color and calc it is nescessary to
vendor the current cssparser-color library into Gecko where all the calc
functionality lives.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 577535
Build 675400: arc lint + arc unit

Event Timeline

tlouw created this revision.Sep 14 2023, 8:04 AM

Herald added a project: secure-revision. · View Herald TranscriptSep 14 2023, 8:04 AM

Harbormaster completed remote builds in B576833: Diff 763475.Sep 14 2023, 8:04 AM

phab-bot published this revision for review.Sep 14 2023, 8:04 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: zrhoffman. · View Herald TranscriptSep 14 2023, 8:04 AM

emilio accepted this revision.Sep 14 2023, 9:46 AM

emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).

This revision is now accepted and ready to land.Sep 14 2023, 9:46 AM

Closed by commit rMOZILLACENTRAL042192d18265: Bug 1851370 - Vendor cssparser-color into Gecko r=emilio (authored by tlouw). · Explain WhySep 14 2023, 11:00 AM

This revision was automatically updated to reflect the committed changes.

tlouw added a commit: rMOZILLACENTRAL042192d18265: Bug 1851370 - Vendor cssparser-color into Gecko r=emilio.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Cargo.lock

servo/

components/

style/

Cargo.toml

1 line

color/

mod.rs

15 lines

73%

values/

computed/

color.rs

2 lines

93%

specified/

calc.rs

2 lines

88%

color.rs

6 lines

90%

ports/

geckolib/

cbindgen.toml

2 lines

	servo/	components/	style/	color/
		third_party/	rust/	cssparser-color/

	parsing.rs
	lib.rs

3 lines

58%

third_party/

rust/

cssparser-color/

Diff 763553

View Options

Cargo.lock

View Options

servo/components/style/Cargo.toml

View Options

servo/components/style/color/mod.rs

View Options

servo/components/style/color/parsing.rs

View Options

servo/components/style/values/computed/color.rs

View Options

servo/components/style/values/specified/calc.rs

View Options

servo/components/style/values/specified/color.rs

View Options

servo/ports/geckolib/cbindgen.toml

View Options

third_party/rust/cssparser-color/.cargo-checksum.json

View Options

third_party/rust/cssparser-color/Cargo.toml

View Options

third_party/rust/cssparser-color/lib.rs

View Options

third_party/rust/cssparser-color/tests.rs

Bug 1851370 - Vendor cssparser-color into Gecko r=emilioClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 763553

Cargo.lock

servo/components/style/Cargo.toml

servo/components/style/color/mod.rs

servo/components/style/color/parsing.rs

servo/components/style/values/computed/color.rs

servo/components/style/values/specified/calc.rs

servo/components/style/values/specified/color.rs

servo/ports/geckolib/cbindgen.toml

third_party/rust/cssparser-color/.cargo-checksum.json

third_party/rust/cssparser-color/Cargo.toml

third_party/rust/cssparser-color/lib.rs

third_party/rust/cssparser-color/tests.rs

Bug 1851370 - Vendor cssparser-color into Gecko r=emilio
ClosedPublic
Actions

Revision Contents
Changeset List