Page MenuHomePhabricator
Differential D187850

Bug 1852084 - Cleanup image function parsing. r=#style,#layout
ClosedPublic
Actions

Authored by emilio on Sep 10 2023, 12:15 PM.
Tags
Referenced Files
F67858570: D187850.1776518003.diff
Fri, Apr 17, 1:13 PM
Unknown Object (File)
Tue, Apr 14, 3:12 AM
Unknown Object (File)
Mon, Apr 13, 9:55 AM
Unknown Object (File)
Sat, Apr 4, 2:09 PM
Unknown Object (File)
Sat, Mar 28, 7:38 PM
Unknown Object (File)
Sat, Mar 28, 11:55 AM
Unknown Object (File)
Mar 8 2026, 5:27 PM
Unknown Object (File)
Mar 7 2026, 10:40 PM
View All 17 Files
Subscribers
reviewbot
zrhoffman

Details

Reviewers
boris
Group Reviewers
Restricted Project
layout-reviewers
Commits
rMOZILLACENTRAL1aad95d98642: Bug 1852084 - Cleanup image function parsing. r=boris
Bugzilla Bug ID
1852084
Summary

Depends on D187765

Diff Detail

Event Timeline

emilio created this revision.Sep 10 2023, 12:15 PM
Herald added a project: secure-revision. · View Herald TranscriptSep 10 2023, 12:15 PM
Harbormaster completed remote builds in B575805: Diff 762055.Sep 10 2023, 12:15 PM
phab-bot published this revision for review.Sep 10 2023, 12:15 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: zrhoffman. · View Herald TranscriptSep 10 2023, 12:15 PM
emilio added a child revision: D187851: Bug 1852084 - Add a -moz-themed(<appearance>) background-image. r=#style,#layout,#desktop-theme-reviewers.Sep 10 2023, 12:15 PM
reviewbot added a subscriber: reviewbot.Sep 10 2023, 12:34 PM

The analysis task source-test-mozlint-license failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

boris accepted this revision as: boris.Sep 11 2023, 11:29 PM
boris added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.Sep 11 2023, 11:29 PM
emilio removed a parent revision: D187765: Bug 1852084 - Don't use foreign drawing to draw titlebar. r=stransky.Sep 12 2023, 7:49 AM
Closed by commit rMOZILLACENTRAL1aad95d98642: Bug 1852084 - Cleanup image function parsing. r=boris (authored by emilio). · Explain WhySep 12 2023, 7:56 AM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRAL1aad95d98642: Bug 1852084 - Cleanup image function parsing. r=boris.
Harbormaster completed remote builds in B577689: Diff 762564.Sep 17 2023, 7:38 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
values/
specified/
131 lines96%
Loading...

Diff 762564

View Options

servo/components/style/values/specified/image.rs

Loading...
Privacy · Cookies · Legal