Paths

Table of Contentst

Differential D187543

Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=#style
ClosedPublic
Actions

Authored by jfkthame on Sep 6 2023, 10:28 AM.

Tags

Referenced Files

	Unknown Object (File)
	Nov 13 2025, 11:53 AM

	Unknown Object (File)
	Oct 15 2025, 9:05 PM

	Unknown Object (File)
	Oct 14 2025, 4:35 PM

	Unknown Object (File)
	Oct 13 2025, 4:36 PM

	Unknown Object (File)
	Aug 5 2025, 11:13 PM

	Unknown Object (File)
	Aug 5 2025, 10:54 AM

	Unknown Object (File)
	Aug 5 2025, 12:59 AM

	Unknown Object (File)
	Aug 2 2025, 1:36 AM

View All 45 Files

Subscribers

Details

Reviewers

Group Reviewers

devtools-reviewers

Commits

rMOZILLACENTRAL2a7646e1a4a5: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools…
rMOZILLACENTRALaf42a433722a: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools…
rMOZILLACENTRAL5926241957b4: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools…

Bugzilla Bug ID

Summary

Just the CSS property; not hooked up to any rendering behavior yet.

Currently this is implemented as a simple longhand text-wrap property,
but we'll want to rename it to text-wrap-style when we update white-space
to be a shorthand and introduce white-space-collapse, text-wrap-mode, etc.

The 'pretty' value is omitted as we have no immediate plans to implement it.
Initially, 'auto' and 'stable' will behave identically, although 'auto' could
change in future once we have higher-quality algorithms available.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 582659
Build 680604: arc lint + arc unit

Event Timeline

jfkthame created this revision.Sep 6 2023, 10:28 AM

Herald added a project: secure-revision. · View Herald TranscriptSep 6 2023, 10:28 AM

Harbormaster completed remote builds in B574717: Diff 760542.Sep 6 2023, 10:28 AM

phab-bot published this revision for review.Sep 6 2023, 10:29 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: devtools-reviewers. · View Herald TranscriptSep 6 2023, 10:29 AM

Herald added subscribers: zrhoffman, emilio. · View Herald Transcript

jfkthame added a child revision: D187544: Bug 1731541 - Implement text-wrap: balance for nsBlockFrame reflow. r=#layout-reviewers.Sep 6 2023, 10:29 AM

emilio accepted this revision as: emilio.Sep 6 2023, 1:53 PM

emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).

emilio removed a reviewer: Restricted Project.

(properties db is soon to be removed in D187492)

This revision is now accepted and ready to land.Sep 6 2023, 9:41 PM

In D187543#6206820, @ochameau wrote:

(properties db is soon to be removed in D187492)

It's gone now! This patch wants to ditch the devtools/shared/css/generated/properties-db.js changes since that file is now gone \o/

layout/style/nsStyleConsts.h
418–419	note: I just filed bug 1852478 on this shorthand conversion for `white-space`, if you want to add a mention of the bug number in the code-comment here. It looks like we don't have a bug for the conversion for `text-wrap` yet (makes sense since it doesn't exist in our tree until this patch lands). Maybe bug 1758391 should be morphed to become that bug? (If so, you might also reference that bug number here.)

jfkthame updated this revision to Diff 762345.Sep 11 2023, 4:28 PM

jfkthame edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B576006: Diff 762345.Sep 11 2023, 4:28 PM

jfkthame updated this revision to Diff 763032.Sep 13 2023, 12:44 PM

Harbormaster completed remote builds in B576487: Diff 763032.Sep 13 2023, 12:44 PM

jfkthame updated this revision to Diff 763331.Sep 13 2023, 10:07 PM

jfkthame edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B576706: Diff 763331.Sep 13 2023, 10:07 PM

Rebase

Harbormaster completed remote builds in B580300: Diff 767142.Sep 23 2023, 10:44 AM

jfkthame updated this revision to Diff 768776.Sep 27 2023, 7:25 PM

jfkthame edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B581638: Diff 768776.Sep 27 2023, 7:25 PM

jfkthame marked an inline comment as done.Sep 28 2023, 8:17 AM

jfkthame updated this revision to Diff 768953.Sep 28 2023, 8:28 AM

Harbormaster completed remote builds in B581805: Diff 768953.Sep 28 2023, 8:28 AM

Closed by commit rMOZILLACENTRAL5926241957b4: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools… (authored by jfkthame). · Explain WhySep 28 2023, 8:38 AM

This revision was automatically updated to reflect the committed changes.

jfkthame added a commit: rMOZILLACENTRAL5926241957b4: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools….

• nataliaCs reopened this revision.Sep 28 2023, 9:13 AM

This revision is now accepted and ready to land.Sep 28 2023, 9:13 AM

• nataliaCs added a reverting change: rMOZILLACENTRAL2f46b4983d1d: Backed out 4 changesets (bug 1731541) for causing bustage on nsBlockFrame.cpp..Sep 28 2023, 9:13 AM

Rebase

Harbormaster completed remote builds in B581979: Diff 769153.Sep 28 2023, 3:18 PM

Rebase

Harbormaster completed remote builds in B582030: Diff 769232.Sep 28 2023, 5:18 PM

Closed by commit rMOZILLACENTRALaf42a433722a: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools… (authored by jfkthame). · Explain WhySep 28 2023, 5:34 PM

This revision was automatically updated to reflect the committed changes.

jfkthame added a commit: rMOZILLACENTRALaf42a433722a: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools….

smolnar reopened this revision.Sep 28 2023, 8:52 PM

This revision is now accepted and ready to land.Sep 28 2023, 8:52 PM

smolnar added a reverting change: rMOZILLACENTRAL2c0444cfb7d6: Backed out 5 changesets (bug 1731541) for causing multiple wpt failures. CLOSED….Sep 28 2023, 8:52 PM

jfkthame updated this revision to Diff 769510.Sep 29 2023, 8:01 AM

Harbormaster completed remote builds in B582256: Diff 769510.Sep 29 2023, 8:01 AM

Closed by commit rMOZILLACENTRAL2a7646e1a4a5: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools… (authored by jfkthame). · Explain WhySep 30 2023, 3:59 PM

This revision was automatically updated to reflect the committed changes.

jfkthame added a commit: rMOZILLACENTRAL2a7646e1a4a5: Bug 1731541 - Add CSS property text-wrap: auto | stable | balance. r=devtools….

Harbormaster completed remote builds in B582659: Diff 769899.Nov 21 2023, 4:41 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

devtools/

server/

actors/

animation-type-longhand.js

1 line

100%

Loading...

layout/

style/

ServoBindings.toml

1 line

-

-

nsStyleConsts.h

11 lines

-

-

nsStyleStruct.h

2 lines

95%

Loading...

nsStyleStruct.cpp

6 lines

93%

Loading...

test/

property_database.js

11 lines

-

-

modules/

libpref/

init/

StaticPrefList.yaml

5 lines

-

-

servo/

components/

style/

properties/

4 lines

-

-

longhands/

inherited_text.mako.rs

12 lines

-

-

Diff 769899

devtools/server/actors/animation-type-longhand.js

Loading...

layout/style/ServoBindings.toml

Loading...

layout/style/nsStyleConsts.h

Loading...

layout/style/nsStyleStruct.h

Loading...

layout/style/nsStyleStruct.cpp

Loading...

layout/style/test/property_database.js

Loading...

modules/libpref/init/StaticPrefList.yaml

Loading...

servo/components/style/properties/data.py

Loading...

servo/components/style/properties/longhands/inherited_text.mako.rs

Loading...