Page MenuHomePhabricator
Differential D185492

Bug 1839837 - Detect default color interpolation method for *-gradient() syntax r=#layout-reviewers
ClosedPublic
Actions

Authored by tlouw on Aug 5 2023, 12:05 AM.
Tags
Referenced Files
Unknown Object (File)
Mar 17 2026, 1:55 PM
Unknown Object (File)
Mar 1 2026, 1:11 AM
Unknown Object (File)
Jan 6 2026, 5:04 PM
Unknown Object (File)
Nov 19 2025, 10:37 PM
Unknown Object (File)
Oct 15 2025, 11:02 AM
Unknown Object (File)
Oct 14 2025, 8:00 PM
Unknown Object (File)
Oct 14 2025, 7:51 AM
Unknown Object (File)
Jun 10 2025, 8:25 AM
View All 15 Files
Subscribers
emilio
zrhoffman

Details

Reviewers
emilio
Group Reviewers
layout-reviewers
Commits
rMOZILLACENTRAL2046d7068c98: Bug 1839837 - Detect default color interpolation method for *-gradient() syntax…
Bugzilla Bug ID
1839837
Summary

The default color interpolation method is detected during parse time.
The equality with the specified method is stored on the gradient and
then during serialization the method is omitted if it was the default.

Diff Detail

Event Timeline

tlouw planned changes to this revision.Aug 5 2023, 12:05 AM
tlouw created this revision.
Herald added a project: secure-revision. · View Herald TranscriptAug 5 2023, 12:05 AM
Harbormaster completed remote builds in B566657: Diff 751081.Aug 5 2023, 12:05 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Aug 5 2023, 12:05 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
tlouw updated this revision to Diff 751096.Aug 5 2023, 9:08 AM
Harbormaster completed remote builds in B566683: Diff 751096.Aug 5 2023, 9:08 AM
tlouw planned changes to this revision.Aug 5 2023, 9:08 AM
tlouw requested review of this revision.Aug 5 2023, 9:13 AM
tlouw updated this revision to Diff 751097.
tlouw retitled this revision from WIP: Bug 1839837 - Detect default color interpolation method for *-gradient() syntax r=#layout-reviewers to Bug 1839837 - Detect default color interpolation method for *-gradient() syntax r=#layout-reviewers.
tlouw added a reviewer: layout-reviewers.
Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptAug 5 2023, 9:13 AM
Harbormaster completed remote builds in B566684: Diff 751097.Aug 5 2023, 9:13 AM
emilio accepted this revision as: emilio.Aug 7 2023, 9:39 AM
emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).
emilio added inline comments.
layout/painting/nsCSSRenderingGradients.cpp
772

Maybe just use !mGradient->Repeating()?

servo/components/style/values/specified/image.rs
102

Just use a slice: &[generic::GradientItem..]

710–711

Maybe just // Legacy gradients always use srgb as a default.

740–741

Same here.

This revision is now accepted and ready to land.Aug 7 2023, 9:39 AM
tlouw marked 4 inline comments as done.Aug 22 2023, 7:12 PM
tlouw updated this revision to Diff 756638.Aug 22 2023, 7:13 PM
Harbormaster completed remote builds in B571414: Diff 756638.Aug 22 2023, 7:13 PM
Closed by commit rMOZILLACENTRAL2046d7068c98: Bug 1839837 - Detect default color interpolation method for *-gradient() syntax… (authored by tlouw). · Explain WhyAug 22 2023, 9:07 PM
This revision was automatically updated to reflect the committed changes.
tlouw added a commit: rMOZILLACENTRAL2046d7068c98: Bug 1839837 - Detect default color interpolation method for *-gradient() syntax….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
layout/
painting/
7 lines90%
Loading...
style/
6 lines99%
Loading...
servo/
components/
style/
values/
generics/
69 lines88%
Loading...
specified/
6 lines90%
Loading...
95 lines94%
Loading...
testing/
web-platform/
meta/
css/
css-images/
parsing/
540 lines--
--

Diff 756688

View Options

layout/painting/nsCSSRenderingGradients.cpp

Loading...
View Options

layout/style/ServoStyleConstsInlines.h

Loading...
View Options

servo/components/style/values/generics/image.rs

Loading...
View Options

servo/components/style/values/specified/color.rs

Loading...
View Options

servo/components/style/values/specified/image.rs

Loading...
View Options

testing/web-platform/meta/css/css-images/parsing/gradient-interpolation-method-computed.html.ini

Loading...
View Options

testing/web-platform/meta/css/css-images/parsing/gradient-interpolation-method-valid.html.ini

Loading...
Privacy · Cookies · Legal