Page MenuHomePhabricator
Differential D185409

Bug 1847182 - Part 5: Don't coerce non-string primitives to strings. r=#spidermonkey-reviewers!
ClosedPublic
Actions

Authored by anba on Aug 4 2023, 9:56 AM.
Tags
Referenced Files
Unknown Object (File)
Oct 15 2025, 7:24 PM
Unknown Object (File)
Jun 18 2025, 4:51 PM
Unknown Object (File)
Apr 13 2025, 11:44 AM
Unknown Object (File)
Apr 4 2025, 1:42 AM
Unknown Object (File)
Apr 3 2025, 9:18 PM
Subscribers
None

Details

Reviewers
allstarschh
Commits
rMOZILLACENTRALd06568a8721f: Bug 1847182 - Part 5: Don't coerce non-string primitives to strings.
Bugzilla Bug ID
1847182
Summary

Implement the changes from https://github.com/tc39/proposal-temporal/pull/2574.

Diff Detail

Event Timeline

anba created this revision.Aug 4 2023, 9:56 AM
Herald added a project: secure-revision. · View Herald TranscriptAug 4 2023, 9:56 AM
Harbormaster completed remote builds in B566334: Diff 750682.Aug 4 2023, 9:56 AM
phab-bot published this revision for review.Aug 4 2023, 9:56 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
anba added a child revision: D185410: Bug 1847182 - Part 6: Move ToString functions into a separate file. r=#spidermonkey-reviewers!.Aug 4 2023, 9:57 AM
mgaudet edited reviewers, added: allstarschh; removed: spidermonkey-reviewers.Aug 4 2023, 4:26 PM
allstarschh accepted this revision.Sep 12 2023, 8:42 AM
allstarschh added a project: testing-exception-elsewhere (Please comment explaining where the tests are).

testing-exception-elsewhere: test262

This revision is now accepted and ready to land.Sep 12 2023, 8:42 AM
anba updated this revision to Diff 762942.Sep 13 2023, 9:51 AM
anba edited the summary of this revision. (Show Details)

Rebase and apply review comments for part 8

Harbormaster completed remote builds in B576426: Diff 762942.Sep 13 2023, 9:51 AM
Closed by commit rMOZILLACENTRALd06568a8721f: Bug 1847182 - Part 5: Don't coerce non-string primitives to strings. (authored by anba). · Explain WhySep 13 2023, 10:09 AM
This revision was automatically updated to reflect the committed changes.
anba added a commit: rMOZILLACENTRALd06568a8721f: Bug 1847182 - Part 5: Don't coerce non-string primitives to strings..

Revision Contents
Changeset List

PathSize
js/
public/
friend/
2 lines
src/
builtin/
temporal/
25 lines
20 lines
45 lines
6 lines
6 lines
6 lines
6 lines
6 lines
22 lines
40 lines
6 lines

Diff 762962

View Options

js/public/friend/ErrorNumbers.msg

Loading...
View Options

js/src/builtin/temporal/Calendar.cpp

Loading...
View Options

js/src/builtin/temporal/Duration.cpp

Loading...
View Options

js/src/builtin/temporal/Instant.cpp

Loading...
View Options

js/src/builtin/temporal/PlainDate.cpp

Loading...
View Options

js/src/builtin/temporal/PlainDateTime.cpp

Loading...
View Options

js/src/builtin/temporal/PlainMonthDay.cpp

Loading...
View Options

js/src/builtin/temporal/PlainTime.cpp

Loading...
View Options

js/src/builtin/temporal/PlainYearMonth.cpp

Loading...
View Options

js/src/builtin/temporal/TemporalFields.cpp

Loading...
View Options

js/src/builtin/temporal/TimeZone.cpp

Loading...
View Options

js/src/builtin/temporal/ZonedDateTime.cpp

Loading...
Privacy · Cookies · Legal