Details

Reviewers

Group Reviewers

Restricted Project
layout-reviewers

Commits

rMOZILLACENTRAL66d3d6c1d7d7: Bug 1844900 - Improve memory usage with nesting. r=dshin
rMOZILLACENTRALc59d018a76ed: Bug 1844900 - Improve memory usage with nesting. r=dshin

Bugzilla Bug ID

1844900

Summary

The idea is to share more memory when expanding nested rules (so being
able to share the whole :is() / :where() allocation), and same for the
Dependency computation (basically, share it across all descendant
selectors).

This prevents exponential explosion in cases like the one in bug 1844446
if you replace tag selectors by class selectors (so that we build
invalidation maps for them).

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 564043
Build 661648: arc lint + arc unit

Event Timeline

emilio created this revision.Jul 22 2023, 4:23 AM

Herald added a project: secure-revision. · View Herald TranscriptJul 22 2023, 4:23 AM

Harbormaster completed remote builds in B562023: Diff 745633.Jul 22 2023, 4:23 AM

phab-bot published this revision for review.Jul 22 2023, 4:23 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: zrhoffman. · View Herald TranscriptJul 22 2023, 4:23 AM

Makes sense - commit message probably could be elaborated to describe the potential issue it's addressing.

This revision is now accepted and ready to land.Jul 27 2023, 5:40 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!