Page MenuHomePhabricator

Bug 1756237 - Make `HTMLEditor::HandleHTMLIndentAroundRanges` validate DOM tree in each time of the loop r=m_kato!
ClosedPublic

Authored by masayuki on Jun 13 2023, 7:30 AM.
Referenced Files
F68091716: D180782.1776798027.diff
Mon, Apr 20, 7:00 PM
F68086321: D180782.1776788664.diff
Mon, Apr 20, 4:24 PM
Unknown Object (File)
Sat, Apr 18, 3:24 AM
Unknown Object (File)
Mon, Apr 6, 4:16 AM
Unknown Object (File)
Wed, Apr 1, 12:00 PM
Unknown Object (File)
Wed, Apr 1, 7:03 AM
Unknown Object (File)
Mar 7 2026, 9:49 AM
Unknown Object (File)
Feb 27 2026, 8:29 PM
Subscribers

Details

Summary

There are 2 possible scenarios which are not handled by the method.

  1. Moving content node to new <blockquote> has already been moved to outside

of the editing host.

  1. There is no container to insert new <blockquote>, e.g., in an inline

editing host.

In the case #1, we should ignore the ex-child node. In the case #2, we should
abort it. Note that Chrome inserts <blockquote> even if there is no proper
container. However, such behavior is disagreed in interop-2023. Therefore,
it's okay just to abort it for now.

Depends on D180781

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 4 defects in diff 728781:

  • 4 defects found by clang-tidy
WARNING: Found 4 defects (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 728781.

This revision is now accepted and ready to land.Jun 14 2023, 12:55 PM