Page MenuHomePhabricator
Differential D180528

Bug 1837734 - Add a way to optimize the "attribute in no namespace exists" check. r=#style,#layout
ClosedPublic
Actions

Authored by emilio on Jun 10 2023, 9:12 AM.
Tags
Referenced Files
Unknown Object (File)
Mon, Apr 6, 7:40 PM
Unknown Object (File)
Oct 16 2025, 3:08 PM
Unknown Object (File)
Oct 15 2025, 4:34 AM
Unknown Object (File)
Oct 13 2025, 4:20 PM
Unknown Object (File)
Jun 17 2025, 8:32 PM
Unknown Object (File)
Jan 4 2025, 10:12 AM
Unknown Object (File)
Jan 1 2025, 6:00 PM
Unknown Object (File)
Jan 1 2025, 8:35 AM
View All 10 Files
Subscribers
None

Details

Reviewers
boris
Group Reviewers
Restricted Project
layout-reviewers
Commits
rMOZILLACENTRAL07170a51344b: Bug 1837734 - Add a way to optimize the "attribute in no namespace exists"…
Bugzilla Bug ID
1837734
Summary

Go through the slow path by default. No behavior change.

Diff Detail

Event Timeline

emilio created this revision.Jun 10 2023, 9:12 AM
Herald added a project: secure-revision. · View Herald TranscriptJun 10 2023, 9:12 AM
Harbormaster completed remote builds in B546928: Diff 727898.Jun 10 2023, 9:12 AM
phab-bot published this revision for review.Jun 10 2023, 9:12 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
emilio added a child revision: D180529: Bug 1837734 - Remove the never_matches field from attr selectors. r=#style,#layout.Jun 10 2023, 9:12 AM
emilio updated this revision to Diff 727914.Jun 10 2023, 10:40 AM
emilio edited the summary of this revision. (Show Details)

Fix some mochitest

Harbormaster completed remote builds in B546944: Diff 727914.Jun 10 2023, 10:40 AM
emilio updated this revision to Diff 728088.Jun 11 2023, 8:30 PM

rebase

Harbormaster completed remote builds in B547128: Diff 728088.Jun 11 2023, 8:30 PM
emilio updated this revision to Diff 729163.Jun 13 2023, 9:44 PM
Harbormaster completed remote builds in B548012: Diff 729163.Jun 13 2023, 9:44 PM
boris accepted this revision as: boris.Jun 14 2023, 7:10 PM
boris added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.Jun 14 2023, 7:10 PM
Closed by commit rMOZILLACENTRAL07170a51344b: Bug 1837734 - Add a way to optimize the "attribute in no namespace exists"… (authored by emilio). · Explain WhyJun 14 2023, 9:23 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRAL07170a51344b: Bug 1837734 - Add a way to optimize the "attribute in no namespace exists"….
Harbormaster completed remote builds in B549190: Diff 729870.Jun 16 2023, 7:19 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
selectors/
6 lines95%
Loading...
11 lines100%
Loading...

Diff 729870

View Options

servo/components/selectors/matching.rs

Loading...
View Options

servo/components/selectors/tree.rs

Loading...
Privacy · Cookies · Legal