Page MenuHomePhabricator

Bug 1835179 - Container units should prevent us from sharing style by rule node. r=dshin,#layout,#style
ClosedPublic

Authored by emilio on May 26 2023, 7:47 PM.
Referenced Files
Unknown Object (File)
Wed, Apr 8, 11:05 AM
Unknown Object (File)
Wed, Apr 8, 10:43 AM
Unknown Object (File)
Tue, Apr 7, 3:44 PM
Unknown Object (File)
Sun, Mar 29, 11:29 AM
Unknown Object (File)
Sun, Mar 29, 11:29 AM
Unknown Object (File)
Mar 15 2026, 1:50 PM
Unknown Object (File)
Mar 1 2026, 8:14 AM
Unknown Object (File)
Oct 15 2025, 6:05 PM
Subscribers

Details

Summary

At least when the containers are different.

For now check that by doing a somewhat simplified test (checking
sibling-ness).

The new flag can be useful to optimize container query restyles on
resizes too, in the future.

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 2 defects in diff 722208:

  • 2 defects found by wptlint-gecko (Mozlint)
IMPORTANT: Found 2 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 722208.

Code analysis found 2 defects in diff 724824:

  • 2 defects found by wptlint-gecko (Mozlint)
IMPORTANT: Found 2 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 724824.

2 defects closed compared to the previous diff 724824.


If you see a problem in this automated review, please report it here.

This revision is now accepted and ready to land.Jun 13 2023, 12:34 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!