Page MenuHomePhabricator
Differential D178105

Bug 1833229 - Move a bit declaration_block and cascade modules. r=#style,#layout
ClosedPublic
Actions

Authored by emilio on May 15 2023, 7:52 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Apr 12, 6:46 AM
Unknown Object (File)
Sun, Apr 12, 1:26 AM
Unknown Object (File)
Sat, Apr 11, 8:24 PM
Unknown Object (File)
Sat, Apr 4, 4:23 PM
Unknown Object (File)
Mon, Mar 30, 3:55 AM
Unknown Object (File)
Mar 14 2026, 12:02 PM
Unknown Object (File)
Mar 14 2026, 1:03 AM
Unknown Object (File)
Feb 26 2026, 4:35 PM
View All 41 Files
Subscribers
None

Details

Reviewers
boris
Group Reviewers
Restricted Project
layout-reviewers
Commits
rMOZILLACENTRALfd1d47cf3e84: Bug 1833229 - Move a bit declaration_block and cascade modules. r=boris
Bugzilla Bug ID
1833229
Summary

So that they aren't imported via #[path]. This allows cargo to see them
even before building.

Diff Detail

Event Timeline

emilio created this revision.May 15 2023, 7:52 PM
Herald added a project: secure-revision. · View Herald TranscriptMay 15 2023, 7:52 PM
Harbormaster completed remote builds in B537422: Diff 716789.May 15 2023, 7:52 PM
phab-bot published this revision for review.May 15 2023, 7:52 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
boris accepted this revision as: boris.May 15 2023, 8:30 PM
boris added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.May 15 2023, 8:30 PM
emilio updated this revision to Diff 716820.May 15 2023, 8:57 PM

Add missing file

Harbormaster completed remote builds in B537442: Diff 716820.May 15 2023, 8:57 PM
Closed by commit rMOZILLACENTRALfd1d47cf3e84: Bug 1833229 - Move a bit declaration_block and cascade modules. r=boris (authored by emilio). · Explain WhyMay 15 2023, 9:04 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRALfd1d47cf3e84: Bug 1833229 - Move a bit declaration_block and cascade modules. r=boris.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
15 lines77%
Loading...
properties/
28 lines98%
Loading...
8 lines89%
Loading...
27 lines--
77 lines--
ports/
geckolib/
2 lines95%
Loading...

Diff 716823

View Options

servo/components/style/lib.rs

Loading...
View Options

servo/components/style/properties/cascade.rs

Loading...
View Options

servo/components/style/properties/declaration_block.rs

Loading...
View Options

servo/components/style/properties/mod.rs

Loading...
View Options

servo/components/style/properties/properties.mako.rs

Loading...
View Options

servo/ports/geckolib/glue.rs

Loading...
Privacy · Cookies · Legal