Details

Reviewers

tlouw
zrhoffman

Group Reviewers

Restricted Project
Restricted Project

Commits

rMOZILLACENTRALb4125fe2a862: Bug 1833151 - [css-nesting] Update cssparser again. r=tlouw,supply-chain…
rMOZILLACENTRAL7abf96264256: Bug 1833151 - [css-nesting] Update cssparser again. r=tlouw,supply-chain…

Bugzilla Bug ID

1833151

Summary

This changes the cssparser setup to:

Avoid having to do copies of the ParsingContext all over the place, which is useful because I plan to stash more nesting state in there.
Use the new RuleBodyParser which allows parsing qualified rules, declarations, and so on. Though we still don't use this anywhere.

The next step is to join NestedRuleParser and PropertyDeclarationParser,
so that we can parse declarations in a lot of the nested rules as well.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 538122
Build 635232: arc lint + arc unit

Event Timeline

emilio created this revision.May 15 2023, 1:44 PM

Herald added a project: secure-revision. · View Herald TranscriptMay 15 2023, 1:44 PM

Harbormaster completed remote builds in B537278: Diff 716609.May 15 2023, 1:44 PM

phab-bot published this revision for review.May 15 2023, 1:44 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 15 2023, 1:44 PM

bholley accepted this revision as: Restricted Project.May 15 2023, 3:56 PM

Looks good, no glaring code issues. Also nice whitespace cleanup.

This revision is now accepted and ready to land.May 16 2023, 9:12 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!