Page MenuHomePhabricator

Bug 1832173 - Finish removing HasArcFFI. r=boris
ClosedPublic

Authored by emilio on May 11 2023, 8:07 PM.
Referenced Files
Unknown Object (File)
Tue, Mar 31, 11:11 PM
Unknown Object (File)
Nov 10 2025, 3:44 AM
Unknown Object (File)
Oct 15 2025, 7:14 AM
Unknown Object (File)
Oct 15 2025, 6:43 AM
Unknown Object (File)
Oct 14 2025, 12:00 AM
Unknown Object (File)
Jul 12 2025, 1:44 PM
Unknown Object (File)
Apr 24 2025, 6:07 AM
Unknown Object (File)
Apr 13 2025, 5:16 AM
Subscribers

Details

Summary

Use the actual Locked<T> types around (via a typedef, just for
convenience).

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 38 defects in the diff 715559:

  • 17 defects found by clang-format
  • 19 defects found by clang-format (Mozlint)
  • 2 defects found by clang-tidy
WARNING: Found 38 issues (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach clang-format -p layout/style/CSSContainerRule.h layout/style/CSSLayerBlockRule.h layout/style/CSSKeyframeRule.h dom/canvas/CanvasRenderingContext2D.cpp layout/style/GeckoBindings.cpp layout/style/CSSPageRule.cpp layout/style/FontFace.h layout/style/StyleAnimationValue.cpp layout/style/StyleSheet.cpp layout/style/CSSFontFaceRule.cpp layout/style/CSSKeyframesRule.h layout/style/MappedDeclarations.h layout/style/CSSStyleRule.h layout/style/nsHTMLStyleSheet.h layout/style/ServoBindings.h layout/style/CSSLayerBlockRule.cpp layout/style/GroupRule.cpp
  • ./mach lint --warnings --outgoing
  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 715559.

Code analysis found 2 defects in the diff 715594:

  • 2 defects found by clang-tidy
WARNING: Found 2 issues (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 715594.

This revision is now accepted and ready to land.May 12 2023, 9:00 PM
This revision is now accepted and ready to land.May 12 2023, 10:21 PM
emilio retitled this revision from Bug 1832173 - Finish removing HasArcFFI. r=#style,#layout to Bug 1832173 - Finish removing HasArcFFI. r=boris.

Fix conflict with bug 1778909