Use the actual Locked<T> types around (via a typedef, just for
convenience).
Details
Details
- Reviewers
boris - Group Reviewers
Restricted Project layout-reviewers - Commits
- rMOZILLACENTRALa226291e5935: Bug 1832173 - Finish removing HasArcFFI. r=boris
rMOZILLACENTRALf6e3d050b3e7: Bug 1832173 - Finish removing HasArcFFI. r=boris - Bugzilla Bug ID
- 1832173
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Build Status
Buildable 536915 Build 633997: arc lint + arc unit
Event Timeline
Comment Actions
Code analysis found 38 defects in the diff 715559:
- 17 defects found by clang-format
- 19 defects found by clang-format (Mozlint)
- 2 defects found by clang-tidy
WARNING: Found 38 issues (warning level) that can be dismissed.
You can run this analysis locally with:
- ./mach clang-format -p layout/style/CSSContainerRule.h layout/style/CSSLayerBlockRule.h layout/style/CSSKeyframeRule.h dom/canvas/CanvasRenderingContext2D.cpp layout/style/GeckoBindings.cpp layout/style/CSSPageRule.cpp layout/style/FontFace.h layout/style/StyleAnimationValue.cpp layout/style/StyleSheet.cpp layout/style/CSSFontFaceRule.cpp layout/style/CSSKeyframesRule.h layout/style/MappedDeclarations.h layout/style/CSSStyleRule.h layout/style/nsHTMLStyleSheet.h layout/style/ServoBindings.h layout/style/CSSLayerBlockRule.cpp layout/style/GroupRule.cpp
- ./mach lint --warnings --outgoing
- ./mach static-analysis check --outgoing (C/C++)
For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 715559.
Comment Actions
Code analysis found 2 defects in the diff 715594:
- 2 defects found by clang-tidy
WARNING: Found 2 issues (warning level) that can be dismissed.
You can run this analysis locally with:
- ./mach static-analysis check --outgoing (C/C++)
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 715594.