Page MenuHomePhabricator
Differential D177515

Bug 1832065 - Remove HasFFI as well. r=#style,#layout
ClosedPublic
Actions

Authored by emilio on May 9 2023, 3:47 PM.
Tags
Referenced Files
Unknown Object (File)
Oct 13 2025, 1:07 PM
Unknown Object (File)
Oct 11 2025, 12:09 AM
Unknown Object (File)
Jul 14 2025, 6:16 AM
Subscribers
None

Details

Reviewers
boris
Group Reviewers
Restricted Project
layout-reviewers
Commits
rMOZILLACENTRAL3a66fe522974: Bug 1832065 - Remove HasFFI as well. r=boris
rMOZILLACENTRAL1260faa596e0: Bug 1832065 - Remove HasFFI as well. r=boris
Bugzilla Bug ID
1832065
Summary

After the previous patches we only have one trait which we should also
tweak / rework, so let's put it all on that single trait.

Diff Detail

Event Timeline

emilio created this revision.May 9 2023, 3:47 PM
Herald added a project: secure-revision. · View Herald TranscriptMay 9 2023, 3:47 PM
Harbormaster completed remote builds in B534976: Diff 713919.May 9 2023, 3:47 PM
phab-bot published this revision for review.May 9 2023, 3:51 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
boris accepted this revision as: boris.May 9 2023, 5:36 PM
boris added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.May 9 2023, 5:36 PM
Closed by commit rMOZILLACENTRAL1260faa596e0: Bug 1832065 - Remove HasFFI as well. r=boris (authored by emilio). · Explain WhyMay 9 2023, 6:17 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRAL1260faa596e0: Bug 1832065 - Remove HasFFI as well. r=boris.
sstanca reopened this revision.May 9 2023, 6:50 PM
This revision is now accepted and ready to land.May 9 2023, 6:50 PM
sstanca added a reverting change: rMOZILLACENTRAL724b1d456369: Backed out 2 changesets (bug 1832065) for glue.rs related bustages. CLOSED TREE.May 9 2023, 6:50 PM
emilio updated this revision to Diff 714111.May 9 2023, 9:03 PM
emilio edited the summary of this revision. (Show Details)

rebase + address ambiguous trait

Harbormaster completed remote builds in B535121: Diff 714111.May 9 2023, 9:03 PM
emilio updated this revision to Diff 714160.May 9 2023, 10:49 PM

Fix opt build

Harbormaster completed remote builds in B535149: Diff 714160.May 9 2023, 10:49 PM
emilio removed a parent revision: D177497: Bug 1832065 - Remove HasSimpleFFI. r=#style,#layout.May 9 2023, 10:50 PM
Closed by commit rMOZILLACENTRAL3a66fe522974: Bug 1832065 - Remove HasFFI as well. r=boris (authored by emilio). · Explain WhyMay 10 2023, 12:01 AM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRAL3a66fe522974: Bug 1832065 - Remove HasFFI as well. r=boris.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
gecko/
5 lines100%
Loading...
gecko_bindings/
sugar/
32 lines37%
Loading...
ports/
geckolib/
14 lines95%
Loading...

Diff 714179

View Options

servo/components/style/gecko/arc_types.rs

Loading...
View Options

servo/components/style/gecko_bindings/sugar/ownership.rs

Loading...
View Options

servo/ports/geckolib/glue.rs

Loading...
Privacy · Cookies · Legal