Paths

Table of Contentst

Differential D177252

Bug 1831539 - Remove HasBoxFFI. r=#style,#layout
ClosedPublic
Actions

Authored by emilio on May 5 2023, 12:18 PM.

Tags

Referenced Files

	Unknown Object (File)
	Oct 15 2025, 7:37 AM

	Unknown Object (File)
	Oct 15 2025, 12:01 AM

	Unknown Object (File)
	Oct 14 2025, 4:27 AM

	Unknown Object (File)
	Jul 18 2025, 2:35 PM

	Unknown Object (File)
	May 27 2025, 7:13 AM

	Unknown Object (File)
	May 12 2025, 5:27 AM

	Unknown Object (File)
	Mar 27 2025, 12:21 AM

	Unknown Object (File)
	Jan 11 2025, 1:14 AM

View All 16 Files

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project
layout-reviewers

Commits

rMOZILLACENTRALa26247c91d0a: Bug 1831539 - Remove HasBoxFFI. r=boris

Bugzilla Bug ID

Summary

HasBoxFFI and HasArcFFI aren't great, see bug 1831242 as for examples of
why.

HasArcFFI requires a bit more care, but HasBoxFFI doesn't give us much
benefit. Instead use the same type in the FFI boundary.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 535204
Build 632265: arc lint + arc unit

Event Timeline

emilio created this revision.May 5 2023, 12:18 PM

Herald added a project: secure-revision. · View Herald TranscriptMay 5 2023, 12:18 PM

Herald added a subscriber: boris. · View Herald Transcript

Harbormaster completed remote builds in B533956: Diff 712679.May 5 2023, 12:18 PM

phab-bot published this revision for review.May 5 2023, 12:20 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

If you split this in two parts, one that keeps the current RawServo* names, and one that changes them, wouldn't this make that first part easier to uplift to esr?

In D177252#5845646, @glandium wrote:

If you split this in two parts, one that keeps the current RawServo* names, and one that changes them, wouldn't this make that first part easier to uplift to esr?

It's not that easy, because the names are generated by cbindgen, so I'd have to change all the forward declarations anyways...

boris accepted this revision as: boris.May 8 2023, 11:53 PM

boris added a project: testing-exception-unchanged (Doesn't change behavior for users).

boris added inline comments.

dom/base/nsINode.cpp
3001–3003	nitpick: Could we use something like `MakeUnique()`?

This revision is now accepted and ready to land.May 8 2023, 11:53 PM

emilio marked an inline comment as done.May 9 2023, 7:10 AM

emilio added inline comments.

dom/base/nsINode.cpp
3001–3003	Not sure how? That'd call operator new etc...

use wrapunique

Harbormaster completed remote builds in B534751: Diff 713671.May 9 2023, 10:09 AM

Closed by commit rMOZILLACENTRALa26247c91d0a: Bug 1831539 - Remove HasBoxFFI. r=boris (authored by emilio). · Explain WhyMay 9 2023, 11:12 AM

This revision was automatically updated to reflect the committed changes.

emilio added a commit: rMOZILLACENTRALa26247c91d0a: Bug 1831539 - Remove HasBoxFFI. r=boris.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

dom/

animation/

2 lines

99%

Loading...

6 lines

95%

Loading...

EffectCompositor.h

8 lines

100%

Loading...

EffectCompositor.cpp

6 lines

91%

Loading...

KeyframeEffect.h

4 lines

100%

Loading...

KeyframeEffect.cpp

40 lines

94%

Loading...

base/

12 lines

96%

Loading...

2 lines

90%

Loading...

4 lines

95%

Loading...

ResponsiveImageSelector.h

2 lines

100%

Loading...

ResponsiveImageSelector.cpp

2 lines

94%

Loading...

8 lines

84%

Loading...

2 lines

93%

Loading...

nsDOMWindowUtils.cpp

2 lines

74%

Loading...

4 lines

98%

Loading...

12 lines

89%

Loading...

layout/

base/

RestyleManager.cpp

2 lines

97%

Loading...

style/

GeckoBindings.h

4 lines

-

-

GeckoBindings.cpp

6 lines

89%

Loading...

GlobalStyleSheetCache.cpp

11 lines

90%

Loading...

14 lines

94%

Loading...

ServoBindingTypes.h

20 lines

100%

Loading...

ServoBindings.h

2 lines

-

-

ServoBindings.toml

5 lines

-

-

ServoBoxedTypeList.h

14 lines

100%

Loading...

ServoCSSParser.cpp

2 lines

100%

Loading...

ServoStyleConstsForwards.h

3 lines

100%

Loading...

ServoStyleConstsInlines.h

6 lines

99%

Loading...

ServoStyleSet.h

6 lines

100%

Loading...

ServoStyleSet.cpp

140 lines

95%

Loading...

ServoStyleSetInlines.h

4 lines

100%

Loading...

StyleAnimationValue.h

2 lines

100%

Loading...

StyleAnimationValue.cpp

8 lines

93%

Loading...

11 lines

97%

Loading...

8 lines

94%

Loading...

StyleSheetInfo.h

2 lines

-

-

nsComputedDOMStyle.cpp

2 lines

87%

Loading...

test/

gtest/

StyloParsingBench.cpp

2 lines

100%

Loading...

servo/

components/

style/

author_styles.rs

17 lines

100%

Loading...

gecko/

-

-

12 lines

72%

Loading...

1 line

-

-

selector_parser.rs

9 lines

96%

Loading...

7 lines

84%

Loading...

gecko_bindings/

sugar/

89 lines

37%

Loading...

use_counters/

13 lines

64%

Loading...

values/

specified/

source_size_list.rs

11 lines

89%

Loading...

ports/

geckolib/

3 lines

-

-

409 lines

95%

Loading...

stylesheet_loader.rs

9 lines

92%

Loading...

widget/

2 lines

72%

Loading...

Diff 713721

dom/animation/Animation.h

Loading...

dom/animation/Animation.cpp

Loading...

dom/animation/EffectCompositor.h

Loading...

dom/animation/EffectCompositor.cpp

Loading...

dom/animation/KeyframeEffect.h

Loading...

dom/animation/KeyframeEffect.cpp

Loading...

dom/base/Document.h

Loading...

dom/base/Document.cpp

Loading...

dom/base/Element.cpp

Loading...

dom/base/ResponsiveImageSelector.h

Loading...

dom/base/ResponsiveImageSelector.cpp

Loading...

dom/base/ShadowRoot.h

Loading...

dom/base/ShadowRoot.cpp

Loading...

dom/base/nsDOMWindowUtils.cpp

Loading...

dom/base/nsINode.h

Loading...

dom/base/nsINode.cpp

Loading...

layout/base/RestyleManager.cpp

Loading...

layout/style/GeckoBindings.h

Loading...

layout/style/GeckoBindings.cpp

Loading...

layout/style/GlobalStyleSheetCache.cpp

Loading...

layout/style/MediaList.cpp

Loading...

layout/style/ServoBindingTypes.h

Loading...

layout/style/ServoBindings.h

Loading...

layout/style/ServoBindings.toml

Loading...

layout/style/ServoBoxedTypeList.h

Loading...

layout/style/ServoCSSParser.cpp

Loading...

layout/style/ServoStyleConstsForwards.h

Loading...

layout/style/ServoStyleConstsInlines.h

Loading...

layout/style/ServoStyleSet.h

Loading...

layout/style/ServoStyleSet.cpp

Loading...

layout/style/ServoStyleSetInlines.h

Loading...

layout/style/StyleAnimationValue.h

Loading...

layout/style/StyleAnimationValue.cpp

Loading...

layout/style/StyleSheet.h

Loading...

layout/style/StyleSheet.cpp

Loading...

layout/style/StyleSheetInfo.h

Loading...

layout/style/nsComputedDOMStyle.cpp

Loading...

layout/style/test/gtest/StyloParsingBench.cpp

Loading...

servo/components/style/author_styles.rs

Loading...

servo/components/style/gecko/boxed_types.rs

Loading...

servo/components/style/gecko/data.rs

Loading...

servo/components/style/gecko/mod.rs

Loading...

servo/components/style/gecko/selector_parser.rs

Loading...

servo/components/style/gecko/wrapper.rs

Loading...

servo/components/style/gecko_bindings/sugar/ownership.rs

Loading...

servo/components/style/use_counters/mod.rs

Loading...

servo/components/style/values/specified/source_size_list.rs

Loading...

servo/ports/geckolib/cbindgen.toml

Loading...

servo/ports/geckolib/glue.rs

Loading...

servo/ports/geckolib/stylesheet_loader.rs

Loading...

widget/IMEData.h

Loading...